Skip to content

[wasi] CI: Add AOT library tests job#95146

Merged
radical merged 14 commits into
dotnet:mainfrom
radical:wasi-aot
Nov 28, 2023
Merged

[wasi] CI: Add AOT library tests job#95146
radical merged 14 commits into
dotnet:mainfrom
radical:wasi-aot

Conversation

@radical

@radical radical commented Nov 22, 2023

Copy link
Copy Markdown
Member
  • misc fixes
  • [wasi] Add support for building AOT library tests on helix
  • [wasi] CI: Add AOT smoke tests
  • Share targets for running AOT tests
  • cleanup

This adds the job to runtime-wasm also, which will run a larger subset of tests but will ignore any failures. For the smoke tests job, failures are not ignored.

@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Nov 22, 2023
@ghost

ghost commented Nov 22, 2023

Copy link
Copy Markdown

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • misc fixes
  • [wasi] Add support for building AOT library tests on helix
  • [wasi] CI: Add AOT smoke tests
  • cleanup
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@radical

radical commented Nov 23, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented Nov 23, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented Nov 23, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

Comment thread eng/testing/tests.browser.targets Outdated
@radical radical requested a review from ilonatommy November 27, 2023 18:58
@radical

radical commented Nov 27, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@radical

radical commented Nov 27, 2023

Copy link
Copy Markdown
Member Author

Failures are unrelated.

Comment thread eng/testing/tests.wasi.targets
@radical

radical commented Nov 28, 2023

Copy link
Copy Markdown
Member Author

/azp run runtime-wasm

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@lewing lewing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue for the unflagged debugger timeout before merging

<_RuntimeIdentifierUsesAppHost>false</_RuntimeIdentifierUsesAppHost>
<TargetArchitecture>wasm</TargetArchitecture>
<TargetOS>Browser</TargetOS>
<TargetOS>wasi</TargetOS>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah... this is where that was coming from.

@radical

radical commented Nov 28, 2023

Copy link
Copy Markdown
Member Author

Please open an issue for the unflagged debugger timeout before merging

Build Analysis is still showing the timeout but the tests were re-run automatically, and didn't fail. I have opened #95343 anyway.

@radical radical merged commit 7c31be1 into dotnet:main Nov 28, 2023
@radical radical deleted the wasi-aot branch November 28, 2023 16:47
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants