Skip to content

[release/8.0-staging] Update APICompat baseline version to 8.0.0#94716

Merged
akoeplinger merged 15 commits into
release/8.0-stagingfrom
ViktorHofer-patch-3
Nov 15, 2023
Merged

[release/8.0-staging] Update APICompat baseline version to 8.0.0#94716
akoeplinger merged 15 commits into
release/8.0-stagingfrom
ViktorHofer-patch-3

Conversation

@ViktorHofer

@ViktorHofer ViktorHofer commented Nov 14, 2023

Copy link
Copy Markdown
Member

Manual backport of #94712
Unblocks #94193

  1. Update APICompat baseline version
  2. Update SDK to 8.0.100
  3. Remove APICompat package reference in favor of what's in the SDK
  4. Update System.Drawing.Common version to 8.0.0
  5. Clear out the ApiCompatBaseline.NetCoreAppLatestStable.xml file as we shouldn't have any public API differences in servicing.

@ghost

ghost commented Nov 14, 2023

Copy link
Copy Markdown

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Manual backport of #94712

Unblocks #94193

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer ViktorHofer changed the title Update APICompat baseline version to 8.0.0 [release/8.0-staging] Update APICompat baseline version to 8.0.0 Nov 14, 2023
Comment thread eng/Version.Details.xml
Comment thread eng/Versions.props
Comment thread src/libraries/apicompat/ApiCompat.proj
@ViktorHofer

ViktorHofer commented Nov 14, 2023

Copy link
Copy Markdown
Member Author

Upgrading to the 8.0.100 SDK:

FAILED: test/ijw/CMakeFiles/ijw.dir/ijw.cpp.obj 
  C:\PROGRA~1\MICROS~1\2022\ENTERP~1\VC\Tools\MSVC\1437~1.328\bin\Hostx86\arm64\cl.exe  /nologo /TP -DDISABLE_CONTRACTS -DHOST_64BIT -DHOST_ARM64 -DHOST_WINDOWS -DNDEBUG -DTARGET_64BIT -DTARGET_ARM64 -DTARGET_WINDOWS -DURTBLDENV_FRIENDLY=Retail -D_FILE_OFFSET_BITS=64 -Dijw_EXPORTS  /DWIN32 /D_WINDOWS    /O2 /Ob2 /DNDEBUG -MD /Ox /nologo /W4 /WX /Oi /Oy- /Gm- /Zp8 /Gy /GS /fp:precise /FC /MP /Zm200 /Zc:strictStrings /Zc:wchar_t /Zc:inline /Zc:forScope /wd4065 /wd4100 /wd4127 /wd4131 /wd4189 /wd4200 /wd4201 /wd4206 /wd4239 /wd4245 /wd4291 /wd4310 /wd4324 /wd4366 /wd4456 /wd4457 /wd4458 /wd4459 /wd4463 /wd4505 /wd4702 /wd4706 /wd4733 /wd4815 /wd4838 /wd4918 /wd4960 /wd4961 /wd5105 /wd5205 /we4007 /we4013 /we4102 /we4551 /we4700 /we4640 /we4806 /w34092 /w34121 /w34125 /w34130 /w34132 /w34212 /w34530 /w35038 /w44177 /Zi /ZH:SHA_256 /source-charset:utf-8 /GL /we4456 /we4457 /we4458 /we4459 /wd4365 /wd4679 /wd5271 /clr:netcore /AID:\a\_work\1\s\.dotnet/packs/Microsoft.NETCore.App.Ref/8.0.0/ref/net8.0 /showIncludes /Fotest\ijw\CMakeFiles\ijw.dir\ijw.cpp.obj /Fdtest\ijw\CMakeFiles\ijw.dir\ /FS -c D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): error C3611: 'System::Numerics::INumberBase::System::IUtf8SpanFormattable.TryFormat': a sealed function cannot have a pure-specifier
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): note: This diagnostic occurred while importing type 'System::Numerics::INumberBase' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): note: This diagnostic occurred while importing type 'System::Numerics::IFloatingPointConstants' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): note: This diagnostic occurred while importing type 'System::Numerics::IFloatingPoint' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): note: This diagnostic occurred while importing type 'System::Decimal' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): error C3611: 'System::Numerics::INumberBase<TSelf>::System::IUtf8SpanFormattable.TryFormat': a sealed function cannot have a pure-specifier
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): note: see reference to class generic instantiation 'System::Numerics::INumberBase<TSelf>' being compiled
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): note: This diagnostic occurred while importing type 'System::Numerics::IFloatingPointConstants' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): note: This diagnostic occurred while importing type 'System::Numerics::IFloatingPoint' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): note: This diagnostic occurred while importing type 'System::Decimal' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): error C3611: 'System::Numerics::INumberBase<System::Decimal>::System::IUtf8SpanFormattable.TryFormat': a sealed function cannot have a pure-specifier
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): note: see reference to class generic instantiation 'System::Numerics::INumberBase<System::Decimal>' being compiled
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): note: see reference to class generic instantiation 'System::Numerics::IFloatingPointConstants<System::Decimal>' being compiled
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): note: see reference to class generic instantiation 'System::Numerics::IFloatingPoint<System::Decimal>' being compiled
  D:\a\_work\1\s\src\native\corehost\test\ijw\ijw.cpp(22): note: This diagnostic occurred while importing type 'System::Decimal' from assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
  [187/206] Building CXX object comhost\CMakeFiles\comhost.dir\__\hostmisc\longfile.windows.cpp.obj
  [188/206] Linking CXX executable test\nativehost\nativehost.exe
  [189/206] Building CXX object comhost\CMakeFiles\comhost.dir\__\hostmisc\pal.windows.cpp.obj
  [190/206] Building CXX object ijwhost\CMakeFiles\ijwhost.dir\ijwhost.cpp.obj
  [191/206] Building CXX object ijwhost\CMakeFiles\ijwhost.dir\ijwthunk.cpp.obj
  ninja: build stopped: subcommand failed.

cc @tannergooding @jkoritzinsky @agocke

Reverting the SDK upgrade in this PR.

@ViktorHofer ViktorHofer added the Servicing-approved Approved for servicing release label Nov 15, 2023
@ViktorHofer

Copy link
Copy Markdown
Member Author

Servicing approved as necessary to ship 8.0.1.

@akoeplinger akoeplinger merged commit 64bff1a into release/8.0-staging Nov 15, 2023
@akoeplinger akoeplinger deleted the ViktorHofer-patch-3 branch November 15, 2023 10:57
@carlossanlop carlossanlop added this to the 8.0.1 milestone Nov 16, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants