diff --git a/src/libraries/pkg/test/frameworkSettings/net5.0/settings.targets b/src/libraries/pkg/test/frameworkSettings/net5.0/settings.targets index a8fa34134f4350..bc6aa5222f1057 100644 --- a/src/libraries/pkg/test/frameworkSettings/net5.0/settings.targets +++ b/src/libraries/pkg/test/frameworkSettings/net5.0/settings.targets @@ -1,7 +1,4 @@ - - $(MicrosoftNETCoreAppVersion) - diff --git a/src/libraries/pkg/test/frameworkSettings/netcoreapp/settings.targets b/src/libraries/pkg/test/frameworkSettings/netcoreapp/settings.targets index ce47469c3e0602..6a7fbbe96d6475 100644 --- a/src/libraries/pkg/test/frameworkSettings/netcoreapp/settings.targets +++ b/src/libraries/pkg/test/frameworkSettings/netcoreapp/settings.targets @@ -4,10 +4,6 @@ true true - - - true - true diff --git a/src/libraries/pkg/test/frameworkSettings/netcoreapp1.0/settings.targets b/src/libraries/pkg/test/frameworkSettings/netcoreapp1.0/settings.targets deleted file mode 100644 index f319b958689917..00000000000000 --- a/src/libraries/pkg/test/frameworkSettings/netcoreapp1.0/settings.targets +++ /dev/null @@ -1,32 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/src/libraries/pkg/test/frameworkSettings/netcoreapp1.1/settings.targets b/src/libraries/pkg/test/frameworkSettings/netcoreapp1.1/settings.targets deleted file mode 100644 index 846df54fdc37b0..00000000000000 --- a/src/libraries/pkg/test/frameworkSettings/netcoreapp1.1/settings.targets +++ /dev/null @@ -1,34 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/src/libraries/pkg/test/frameworkSettings/netcoreapp2.0/settings.targets b/src/libraries/pkg/test/frameworkSettings/netcoreapp2.0/settings.targets deleted file mode 100644 index 4cfa63c93a5f02..00000000000000 --- a/src/libraries/pkg/test/frameworkSettings/netcoreapp2.0/settings.targets +++ /dev/null @@ -1,8 +0,0 @@ - - - - - - - \ No newline at end of file diff --git a/src/libraries/pkg/test/frameworkSettings/netstandard/settings.targets b/src/libraries/pkg/test/frameworkSettings/netstandard/settings.targets index af593ca8234cb2..e25068d3eceb1c 100644 --- a/src/libraries/pkg/test/frameworkSettings/netstandard/settings.targets +++ b/src/libraries/pkg/test/frameworkSettings/netstandard/settings.targets @@ -14,4 +14,12 @@ + + + + + <_RuntimeAssetsForConflictResolution Include="@(Reference)" Condition="'%(Reference.NuGetPackageId)' == 'NETStandard.Library' or '%(Reference.NuGetPackageId)' == 'NETStandard.Library.Ref'" /> + + \ No newline at end of file diff --git a/src/libraries/pkg/test/frameworkSettings/netstandard2.1/settings.targets b/src/libraries/pkg/test/frameworkSettings/netstandard2.1/settings.targets deleted file mode 100644 index 1fbde1af9ed94e..00000000000000 --- a/src/libraries/pkg/test/frameworkSettings/netstandard2.1/settings.targets +++ /dev/null @@ -1,90 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/src/libraries/pkg/test/frameworkSettings/portable-net45+win8+wp8+wpa81/settings.targets b/src/libraries/pkg/test/frameworkSettings/portable-net45+win8+wp8+wpa81/settings.targets deleted file mode 100644 index 72095adf9916ef..00000000000000 --- a/src/libraries/pkg/test/frameworkSettings/portable-net45+win8+wp8+wpa81/settings.targets +++ /dev/null @@ -1,7 +0,0 @@ - - - .NETPortable - v4.5 - Profile259 - - \ No newline at end of file diff --git a/src/libraries/pkg/test/frameworkSettings/portable-net45+win8+wpa81/settings.targets b/src/libraries/pkg/test/frameworkSettings/portable-net45+win8+wpa81/settings.targets deleted file mode 100644 index 77255b7800253a..00000000000000 --- a/src/libraries/pkg/test/frameworkSettings/portable-net45+win8+wpa81/settings.targets +++ /dev/null @@ -1,7 +0,0 @@ - - - .NETPortable - v4.5 - Profile111 - - \ No newline at end of file diff --git a/src/libraries/pkg/test/frameworkSettings/portable-net45+win8/settings.targets b/src/libraries/pkg/test/frameworkSettings/portable-net45+win8/settings.targets deleted file mode 100644 index e488ebf9aa53af..00000000000000 --- a/src/libraries/pkg/test/frameworkSettings/portable-net45+win8/settings.targets +++ /dev/null @@ -1,7 +0,0 @@ - - - .NETPortable - v4.5 - Profile7 - - \ No newline at end of file diff --git a/src/libraries/pkg/test/frameworkSettings/portable45-net45+win8/settings.targets b/src/libraries/pkg/test/frameworkSettings/portable45-net45+win8/settings.targets deleted file mode 100644 index e488ebf9aa53af..00000000000000 --- a/src/libraries/pkg/test/frameworkSettings/portable45-net45+win8/settings.targets +++ /dev/null @@ -1,7 +0,0 @@ - - - .NETPortable - v4.5 - Profile7 - - \ No newline at end of file diff --git a/src/libraries/pkg/test/frameworkSettings/portable46-net451+win81/settings.targets b/src/libraries/pkg/test/frameworkSettings/portable46-net451+win81/settings.targets deleted file mode 100644 index 463ffc65f149fa..00000000000000 --- a/src/libraries/pkg/test/frameworkSettings/portable46-net451+win81/settings.targets +++ /dev/null @@ -1,7 +0,0 @@ - - - .NETPortable - v4.6 - Profile44 - - \ No newline at end of file diff --git a/src/libraries/pkg/test/packageTest.targets b/src/libraries/pkg/test/packageTest.targets index 81bb15d99b9252..29015e217fd70a 100644 --- a/src/libraries/pkg/test/packageTest.targets +++ b/src/libraries/pkg/test/packageTest.targets @@ -1,10 +1,12 @@ - - + <_targetFrameworkVersionIndex>$(TargetFramework.IndexOfAny(".-0123456789")) <_targetFrameworkIdentifier Condition="'$(_runtimeOSVersionIndex)' != '-1'">$(TargetFramework.SubString(0, $(_targetFrameworkVersionIndex))) <_targetFrameworkIdentifier Condition="'$(_targetFrameworkIdentifier)' == 'net' and !$(TargetFramework.StartsWith('net4'))">netcoreapp + + + $(MSBuildThisFileDirectory)tools\ @@ -14,6 +16,9 @@ https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6-transport/nuget/v3/index.json; $(LocalPackagesPath) + + + true @@ -21,8 +26,8 @@ - - + + @@ -31,17 +36,14 @@ + - - <_message>Testing $(TestPackageID) TFM=$(TargetFramework) - <_message Condition="'$(RuntimeIdentifier)' != ''">$(_message) RID=$(RuntimeIdentifier) - - + + Condition="'$(ShouldVerifyClosure)' == 'true'"> <_refClosureFileNames Include="@(ReferencePath->'%(FileName)')"> %(Identity) @@ -57,7 +59,7 @@ + Condition="'$(ShouldVerifyTypes)' == 'true'"> <_refTypesFileNames Include="@(ReferencePath->'%(FileName)')"> %(Identity) @@ -71,11 +73,37 @@ IgnoredTypes="@(IgnoredTypes)" /> + + + + + + + + + + + + + <_referenceCopyLocalPathsPackages Include="@(ReferenceCopyLocalPaths->'%(NuGetPackageId)')" + Condition="'%(ReferenceCopyLocalPaths.RuntimeIdentifier)' == ''" + Exclude="@(ReferencePath->'%(NuGetPackageId)');$(TestPackageId)" /> + + + + + + + + + Inputs="%(RuntimeLibToTest.RuntimeIdentifier)" + Outputs="unused" + DependsOnTargets="PrepareForRuntimeTesting" + Condition="'$(ShouldVerifyClosure)' == 'true' and '$(SkipVerifyClosureForRuntime)' != 'true'"> + - <_runClosureFileNames Include="@(ReferenceCopyLocalPaths->'%(FileName)')"> + <_runClosureFileNames Include="@(RuntimeLibToTestDependency->'%(FileName)');@(RuntimeLibToTest->'%(FileName)')"> %(Identity) <_runClosureFileNamesFiltered Include="@(_runClosureFileNames)" Exclude="@(ExcludeFromClosure);@(ExcludeFromClosure->'%(Identity).ni')"/> @@ -88,10 +116,13 @@ + Inputs="%(RuntimeLibToTest.RuntimeIdentifier)" + Outputs="unused" + DependsOnTargets="PrepareForRuntimeTesting" + Condition="'$(ShouldVerifyTypes)' == 'true'"> + - <_runTypesFileNames Include="@(ReferenceCopyLocalPaths->'%(FileName)')"> + <_runTypesFileNames Include="@(RuntimeLibToTestDependency->'%(FileName)');@(RuntimeLibToTest->'%(FileName)')"> %(Identity) <_runTypesFileNamesFiltered Include="@(_runTypesFileNames)" Exclude="@(ExcludeFromTypes);@(ExcludeFromTypes->'%(Identity).ni')"/> @@ -105,55 +136,22 @@ + Condition="'$(_ShortFrameworkIdentifier)' == 'net' AND '$(_TargetFrameworkVersionWithoutV)' >= '4.6.1' AND '$(DisableVerifyNotDependsOnNetStandardTest)' != 'true'"> - <_testDependsOn> + LogBeginTest; VerifyNotDependsOnNetStandard; VerifyReferenceClosure; VerifyReferenceTypes; VerifyRuntimeClosure; VerifyRuntimeTypes; - + + Test - - - - - - - - - <_projectRuntime Include="$(RuntimeIdentifiers)" /> - - - - $(IntermediateOutputPath)\.testComplete - - - $(IntermediateOutputPath)\%(_projectRuntime.Identity).testComplete - RuntimeIdentifier=%(_projectRuntime.Identity) - - - - - - - _getTestProjects - - $(TestDependsOn);ResolveReferences - - - - + diff --git a/src/libraries/pkg/test/project.csproj.template b/src/libraries/pkg/test/project.csproj.template index 9e6ab08111971c..eb0b959b521e6f 100644 --- a/src/libraries/pkg/test/project.csproj.template +++ b/src/libraries/pkg/test/project.csproj.template @@ -1,8 +1,7 @@ - {TFM} - {RIDs} + {TFMs} {PackageId} {PackageVersion} diff --git a/src/libraries/pkg/test/test.msbuild b/src/libraries/pkg/test/test.msbuild index 6d0a6a47c6d117..e7ad573abf4dff 100644 --- a/src/libraries/pkg/test/test.msbuild +++ b/src/libraries/pkg/test/test.msbuild @@ -27,6 +27,6 @@ - + \ No newline at end of file diff --git a/src/libraries/pkg/test/testPackages.proj b/src/libraries/pkg/test/testPackages.proj index 2dcacddce6c578..872a3da0a1f645 100644 --- a/src/libraries/pkg/test/testPackages.proj +++ b/src/libraries/pkg/test/testPackages.proj @@ -12,7 +12,6 @@ - @@ -26,9 +25,6 @@ - - - @@ -91,7 +87,7 @@ - $(TestProjectDir)%(Identity)/%(TargetFrameworkShort)/ + $(TestProjectDir)%(Identity)/ %(ProjectDir)project.csproj @@ -114,23 +110,6 @@ - - - <_supportedPackageRuntimes Remove="@(_supportedPackageRuntimes)" /> - <_supportedPackageRuntimes Include="%(SupportedPackage.RuntimeIdentifiers)" /> - - <_supportedPackageRuntimesToRemove Include="@(_supportedPackageRuntimes)" Exclude="@(RuntimesToInclude)" Condition="'@(RuntimesToInclude)' != ''" /> - <_filteredSupportedPackageRuntimes Include="@(_supportedPackageRuntimes)" Exclude="@(RuntimesToExclude);@(_supportedPackageRuntimesToRemove)" /> - - - @(_filteredSupportedPackageRuntimes) - - - - %(SupportedPackage.ProjectFile) <_packageId>%(SupportedPackage.Identity) <_packageVersion>%(SupportedPackage.Version) - <_projectTFM>%(SupportedPackage.TargetFrameworkShort) - <_projectRIDs>%(SupportedPackage.RuntimeIdentifiers) + <_projectTFMs>@(SupportedPackage->'%(TargetFrameworkShort)') - + diff --git a/src/libraries/sendtohelixhelp.proj b/src/libraries/sendtohelixhelp.proj index 3001a00bc110ec..e048a7101c7439 100644 --- a/src/libraries/sendtohelixhelp.proj +++ b/src/libraries/sendtohelixhelp.proj @@ -54,7 +54,7 @@ - + true true @@ -80,9 +80,9 @@ dotnet msbuild %HELIX_CORRELATION_PAYLOAD%\test.msbuild + $(HelixCommand) /bl:%HELIX_WORKITEM_UPLOAD_ROOT%\%HELIX_WORKITEM_FRIENDLYNAME%.package.test.binlog $(HelixCommand) /warnaserror $(HelixCommand) /p:PackageTestProjectsDir=%HELIX_WORKITEM_PAYLOAD% - $(HelixCommand) /p:RestorePackagesPath=%HELIX_WORKITEM_PAYLOAD%\packages $(HelixCommand) /p:LocalPackagesPath="%HELIX_CORRELATION_PAYLOAD%\packages\"