From 870086cdc47a7cb05057040d00f12d944be81111 Mon Sep 17 00:00:00 2001 From: Ulrich Weigand Date: Tue, 16 Mar 2021 10:09:39 +0100 Subject: [PATCH] Big-endian test case fixes: BinaryWriter * Fix endian assumption in BinaryWriter_WriteSpan (BinaryWriter always uses little-endian byte order) --- .../tests/BinaryWriter/BinaryWriter.WriteByteCharTests.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libraries/System.IO/tests/BinaryWriter/BinaryWriter.WriteByteCharTests.cs b/src/libraries/System.IO/tests/BinaryWriter/BinaryWriter.WriteByteCharTests.cs index d1a85304ae59a5..84a1fc2b1c447d 100644 --- a/src/libraries/System.IO/tests/BinaryWriter/BinaryWriter.WriteByteCharTests.cs +++ b/src/libraries/System.IO/tests/BinaryWriter/BinaryWriter.WriteByteCharTests.cs @@ -579,13 +579,13 @@ public void BinaryWriter_WriteSpan() char testChar; - testChar = BitConverter.ToChar(new byte[] { (byte)baseStream.ReadByte(), (byte)baseStream.ReadByte() }, 0); + testChar = (char)((ushort)baseStream.ReadByte() + ((ushort)baseStream.ReadByte() << 8)); Assert.Equal('a', testChar); - testChar = BitConverter.ToChar(new byte[] { (byte)baseStream.ReadByte(), (byte)baseStream.ReadByte() }, 0); + testChar = (char)((ushort)baseStream.ReadByte() + ((ushort)baseStream.ReadByte() << 8)); Assert.Equal('7', testChar); - testChar = BitConverter.ToChar(new byte[] { (byte)baseStream.ReadByte(), (byte)baseStream.ReadByte() }, 0); + testChar = (char)((ushort)baseStream.ReadByte() + ((ushort)baseStream.ReadByte() << 8)); Assert.Equal(char.MaxValue, testChar); } }