From 41820c2f535992461cd11819371b1ae77db87f94 Mon Sep 17 00:00:00 2001 From: Stephen Toub Date: Thu, 11 Mar 2021 10:35:02 -0500 Subject: [PATCH] Remove a few StringBuilder uses from TraceListener --- .../src/System/Diagnostics/TraceListener.cs | 28 +++---------------- 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/src/libraries/System.Diagnostics.TraceSource/src/System/Diagnostics/TraceListener.cs b/src/libraries/System.Diagnostics.TraceSource/src/System/Diagnostics/TraceListener.cs index b32f8858545438..945dc200c3afd0 100644 --- a/src/libraries/System.Diagnostics.TraceSource/src/System/Diagnostics/TraceListener.cs +++ b/src/libraries/System.Diagnostics.TraceSource/src/System/Diagnostics/TraceListener.cs @@ -200,17 +200,9 @@ public virtual void Fail(string? message) /// public virtual void Fail(string? message, string? detailMessage) { - StringBuilder failMessage = new StringBuilder(); - failMessage.Append(SR.TraceListenerFail); - failMessage.Append(' '); - failMessage.Append(message); - if (detailMessage != null) - { - failMessage.Append(' '); - failMessage.Append(detailMessage); - } - - WriteLine(failMessage.ToString()); + WriteLine(detailMessage is null ? + SR.TraceListenerFail + " " + message : + SR.TraceListenerFail + " " + message + " " + detailMessage); } /// @@ -360,19 +352,7 @@ public virtual void TraceData(TraceEventCache? eventCache, string source, TraceE WriteHeader(source, eventType, id); - StringBuilder sb = new StringBuilder(); - if (data != null) - { - for (int i = 0; i < data.Length; i++) - { - if (i != 0) - sb.Append(", "); - - if (data[i] != null) - sb.Append(data[i]!.ToString()); - } - } - WriteLine(sb.ToString()); + WriteLine(data != null ? string.Join(", ", data) : string.Empty); WriteFooter(eventCache); }