From 61d4e3611ba6f68ccbf5dca2dfd6843b9f42bb6c Mon Sep 17 00:00:00 2001 From: Jeremy Barton Date: Wed, 8 Jul 2020 19:20:22 +0000 Subject: [PATCH] Make DSAKeyValueTests.LoadXml accept seed/counter may not roundtrip. --- .../tests/DSAKeyValueTest.cs | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/libraries/System.Security.Cryptography.Xml/tests/DSAKeyValueTest.cs b/src/libraries/System.Security.Cryptography.Xml/tests/DSAKeyValueTest.cs index 05dd07958494db..8d9409cccc75a2 100644 --- a/src/libraries/System.Security.Cryptography.Xml/tests/DSAKeyValueTest.cs +++ b/src/libraries/System.Security.Cryptography.Xml/tests/DSAKeyValueTest.cs @@ -92,7 +92,6 @@ public void GetXml_SameDsa() } } - [ActiveIssue("https://github.com/dotnet/runtime/issues/34786", TestPlatforms.AnyUnix)] [Fact] public void LoadXml() { @@ -115,9 +114,14 @@ public void LoadXml() Assert.Equal(Convert.ToBase64String(parameters.Q), qValue); Assert.Equal(Convert.ToBase64String(parameters.G), gValue); Assert.Equal(Convert.ToBase64String(parameters.Y), yValue); - Assert.NotNull(parameters.Seed); - Assert.Equal(Convert.ToBase64String(parameters.Seed), seedValue); - Assert.Equal(BitConverter.GetBytes(parameters.Counter)[0], Convert.FromBase64String(pgenCounterValue)[0]); + + // Not all providers support round-tripping the seed value. + // Seed and PGenCounter are round-tripped together. + if (parameters.Seed != null) + { + Assert.Equal(Convert.ToBase64String(parameters.Seed), seedValue); + Assert.Equal(BitConverter.GetBytes(parameters.Counter)[0], Convert.FromBase64String(pgenCounterValue)[0]); + } } [Fact]