Skip to content

Commit 20b42d5

Browse files
authored
re-enable tests for 66421 (#73052)
1 parent c734a8e commit 20b42d5

File tree

2 files changed

+0
-33
lines changed

2 files changed

+0
-33
lines changed

src/libraries/System.Text.Json/tests/Common/ReferenceHandlerTests/ReferenceHandlerTests.IgnoreCycles.cs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,6 @@ public async Task IgnoreCycles_OnDictionary(Type typeToSerialize)
134134
}
135135

136136
[Fact]
137-
#if BUILDING_SOURCE_GENERATOR_TESTS
138-
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
139-
#endif
140137
public async Task IgnoreCycles_OnRecursiveDictionary()
141138
{
142139
var root = new RecursiveDictionary();
@@ -183,9 +180,6 @@ public async Task IgnoreCycles_OnList(Type typeToSerialize)
183180
}
184181

185182
[Fact]
186-
#if BUILDING_SOURCE_GENERATOR_TESTS
187-
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
188-
#endif
189183
public async Task IgnoreCycles_OnRecursiveList()
190184
{
191185
var root = new RecursiveList();
@@ -240,9 +234,6 @@ public async Task IgnoreCycles_OnExtensionData()
240234
}
241235

242236
[Fact]
243-
#if BUILDING_SOURCE_GENERATOR_TESTS
244-
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
245-
#endif
246237
public async Task IgnoreCycles_DoesNotSupportPreserveSemantics()
247238
{
248239
// Object
@@ -279,9 +270,6 @@ public async Task IgnoreCycles_DoesNotSupportPreserveSemantics()
279270
}
280271

281272
[Fact]
282-
#if BUILDING_SOURCE_GENERATOR_TESTS
283-
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
284-
#endif
285273
public async Task IgnoreCycles_DoesNotSupportPreserveSemantics_Polymorphic()
286274
{
287275
// Object

src/libraries/System.Text.Json/tests/Common/ReferenceHandlerTests/ReferenceHandlerTests.cs

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -242,9 +242,6 @@ public async Task UnicodePropertyNames()
242242
public class DictionaryWithGenericCycle : Dictionary<string, DictionaryWithGenericCycle> { }
243243

244244
[Fact]
245-
#if BUILDING_SOURCE_GENERATOR_TESTS
246-
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
247-
#endif
248245
public async Task DictionaryLoop()
249246
{
250247
DictionaryWithGenericCycle root = new DictionaryWithGenericCycle();
@@ -261,9 +258,6 @@ public async Task DictionaryLoop()
261258
}
262259

263260
[Fact]
264-
#if BUILDING_SOURCE_GENERATOR_TESTS
265-
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
266-
#endif
267261
public async Task DictionaryPreserveDuplicateDictionaries()
268262
{
269263
DictionaryWithGenericCycle root = new DictionaryWithGenericCycle();
@@ -298,9 +292,6 @@ public async Task DictionaryObjectLoop()
298292
public class DictionaryWithGenericCycleWithinList : Dictionary<string, List<DictionaryWithGenericCycleWithinList>> { }
299293

300294
[Fact]
301-
#if BUILDING_SOURCE_GENERATOR_TESTS
302-
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
303-
#endif
304295
public async Task DictionaryArrayLoop()
305296
{
306297
DictionaryWithGenericCycleWithinList root = new DictionaryWithGenericCycleWithinList();
@@ -316,9 +307,6 @@ public async Task DictionaryArrayLoop()
316307
}
317308

318309
[Fact]
319-
#if BUILDING_SOURCE_GENERATOR_TESTS
320-
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
321-
#endif
322310
public async Task DictionaryPreserveDuplicateArrays()
323311
{
324312
DictionaryWithGenericCycleWithinList root = new DictionaryWithGenericCycleWithinList();
@@ -449,9 +437,6 @@ public async Task UnicodeDictionaryKeys()
449437
public class ListWithGenericCycle : List<ListWithGenericCycle> { }
450438

451439
[Fact]
452-
#if BUILDING_SOURCE_GENERATOR_TESTS
453-
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
454-
#endif
455440
public async Task ArrayLoop()
456441
{
457442
ListWithGenericCycle root = new ListWithGenericCycle();
@@ -518,9 +503,6 @@ public async Task ArrayPreserveDuplicateObjects()
518503
public class ListWithGenericCycleWithinDictionary : List<Dictionary<string, ListWithGenericCycleWithinDictionary>> { }
519504

520505
[Fact]
521-
#if BUILDING_SOURCE_GENERATOR_TESTS
522-
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
523-
#endif
524506
public async Task ArrayDictionaryLoop()
525507
{
526508
ListWithGenericCycleWithinDictionary root = new ListWithGenericCycleWithinDictionary();
@@ -536,9 +518,6 @@ public async Task ArrayDictionaryLoop()
536518
}
537519

538520
[Fact]
539-
#if BUILDING_SOURCE_GENERATOR_TESTS
540-
[ActiveIssue("https://github.com/dotnet/runtime/issues/66421")]
541-
#endif
542521
public async Task ArrayPreserveDuplicateDictionaries()
543522
{
544523
ListWithGenericCycleWithinDictionary root = new ListWithGenericCycleWithinDictionary

0 commit comments

Comments
 (0)