Remove validation that was causing test failures

Co-authored-by: rzikm <32671551+rzikm@users.noreply.github.com>

Author: Copilot

src/libraries/System.Formats.Tar/src/Resources/Strings.resx

@@ -205,9 +205,6 @@
   <data name="TarExtAttrDisallowedValueChar" xml:space="preserve">
     <value>The value of the extended attribute key '{0}' contains a disallowed '{1}' character.</value>
   </data>
-  <data name="TarExtendedAttributeConflict" xml:space="preserve">
-    <value>The extended attribute '{0}' with value '{1}' conflicts with the corresponding property value '{2}'.</value>
-  </data>
   <data name="TarStreamSeekabilityUnsupportedCombination" xml:space="preserve">
     <value>Cannot write the unseekable data stream of entry '{0}' into an unseekable archive stream.</value>
   </data>

src/libraries/System.Formats.Tar/src/System/Formats/Tar/PaxTarEntry.cs

@@ -69,7 +69,6 @@ public PaxTarEntry(TarEntryType entryType, string entryName, IEnumerable<KeyValu
 
             _header._prefix = string.Empty;
             _header.AddExtendedAttributes(extendedAttributes);
-            _header.ValidateExtendedAttributesAgainstProperties();
         }
 
         /// <summary>
@@ -92,7 +91,6 @@ public PaxTarEntry(TarEntry other)
             if (other is PaxTarEntry paxOther)
             {
                 _header.AddExtendedAttributes(paxOther.ExtendedAttributes);
-                _header.ValidateExtendedAttributesAgainstProperties();
             }
             else if (other is GnuTarEntry gnuOther)
             {

src/libraries/System.Formats.Tar/src/System/Formats/Tar/TarHeader.cs

@@ -198,28 +198,5 @@ internal void SyncNumericExtendedAttribute(string key, int value)
                 }
             }
         }
-
-        // Validates that extended attributes don't conflict with property values.
-        // This is called after AddExtendedAttributes to ensure consistency.
-        internal void ValidateExtendedAttributesAgainstProperties()
-        {
-            if (_format != TarEntryFormat.Pax || _ea is null)
-            {
-                return;
-            }
-
-            // Validate path - must match entryName if provided
-            if (_ea.TryGetValue(PaxEaName, out string? eaPath) && eaPath != _name)
-            {
-                throw new ArgumentException(SR.Format(SR.TarExtendedAttributeConflict, PaxEaName, eaPath, _name));
-            }
-
-            // Skip mtime validation - it's auto-set to UtcNow and extended attribute may intentionally override it
-
-            // Skip other property validations since:
-            // 1. Properties may have default values that conflict with intentional extended attributes
-            // 2. The synchronization mechanism ensures properties take precedence when writing
-            // 3. Extended attributes for non-default properties will be validated when properties are set
-        }
     }
 }

src/libraries/System.Formats.Tar/tests/TarEntry/PaxTarEntry.ExtendedAttributes.Tests.cs

@@ -235,32 +235,49 @@ public void CopyConstructor_ModificationTime_ShouldOverrideExtendedAttributes()
         }
 
         [Fact]
-        public void Constructor_WithConflictingPathExtendedAttribute_ShouldThrow()
+        public void Constructor_WithConflictingPathExtendedAttribute_PropertyTakesPrecedence()
         {
-            // Extended attribute path conflicts with entryName parameter
+            // Extended attribute path differs from entryName parameter
+            // When written, the property value (entryName) should take precedence
             Dictionary<string, string> extendedAttributes = new Dictionary<string, string>
             {
                 { "path", "different.txt" }
             };
 
-            ArgumentException ex = Assert.Throws<ArgumentException>(() =>
-                new PaxTarEntry(TarEntryType.RegularFile, "test.txt", extendedAttributes));
+            // This should not throw - extended attributes can differ from properties
+            // The synchronization mechanism ensures properties take precedence when writing
+            PaxTarEntry entry = new PaxTarEntry(TarEntryType.RegularFile, "test.txt", extendedAttributes);
+            
+            // The extended attribute was added as-is initially
+            Assert.True(entry.ExtendedAttributes.ContainsKey("path"));
+            Assert.Equal("different.txt", entry.ExtendedAttributes["path"]);
 
-            Assert.Contains("path", ex.Message);
-            Assert.Contains("different.txt", ex.Message);
-            Assert.Contains("test.txt", ex.Message);
+            // Write and read back to verify property takes precedence
+            using MemoryStream archiveStream = new MemoryStream();
+            using (TarWriter writer = new TarWriter(archiveStream, leaveOpen: true))
+            {
+                writer.WriteEntry(entry);
+            }
+
+            archiveStream.Position = 0;
+            using (TarReader reader = new TarReader(archiveStream))
+            {
+                PaxTarEntry readEntry = reader.GetNextEntry() as PaxTarEntry;
+                Assert.NotNull(readEntry);
+                // The name from the property (test.txt) should be used, not the extended attribute
+                Assert.Equal("test.txt", readEntry.Name);
+            }
         }
 
         [Fact]
         public void Constructor_WithMatchingExtendedAttributes_ShouldSucceed()
         {
-            // Extended attributes that match entryName should not throw
+            // Extended attributes that match entryName should work fine
             Dictionary<string, string> extendedAttributes = new Dictionary<string, string>
             {
                 { "path", "test.txt" }
             };
 
-            // This should not throw because path matches entryName
             PaxTarEntry entry = new PaxTarEntry(TarEntryType.RegularFile, "test.txt", extendedAttributes);
 
             Assert.True(entry.ExtendedAttributes.ContainsKey("path"));