From 61ce8fa27a06eaed73100f4f23a64c7505802a04 Mon Sep 17 00:00:00 2001 From: "Ahmet Ibrahim Aksoy (from Dev Box)" Date: Wed, 4 Oct 2023 17:03:27 +0200 Subject: [PATCH 1/3] Document the behavior of side effect on UseDefaultCredentials property --- xml/System.Net.Http/HttpClientHandler.xml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/xml/System.Net.Http/HttpClientHandler.xml b/xml/System.Net.Http/HttpClientHandler.xml index f121fbf9901..3eb758f2342 100644 --- a/xml/System.Net.Http/HttpClientHandler.xml +++ b/xml/System.Net.Http/HttpClientHandler.xml @@ -482,7 +482,13 @@ On .NET Core, the key usage attribute on the X509 certificate, if present, is re Gets or sets authentication information used by this handler. The authentication credentials associated with the handler. The default is . - To be added. + + property has been setted to `true` then, it has side effect on this property, and this property will be setted to . + ]]> + @@ -1451,6 +1457,8 @@ handler.ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousA Set this property to `true` when requests made by the object should, if requested by the server, be authenticated using the credentials of the currently logged on user. For client applications, this is the desired behavior in most scenarios. For middle-tier applications, such as ASP.NET applications, instead of using this property, you would typically set the property to the credentials of the client on whose behalf the request is made. This property doesn't affect proxy credentials. When the default (system) proxy is being used, set credentials explicitly by using the property. When the proxy is set by the property, set credentials for the proxy via its property. + + If this property has been setted to `true` then, it has side effect on property, and will be setted to . ]]> From 39c4c539e74f6a6dab5d9c7fb5e77391fcfa3cec Mon Sep 17 00:00:00 2001 From: Ahmet Ibrahim Aksoy Date: Wed, 4 Oct 2023 19:14:25 +0200 Subject: [PATCH 2/3] Update HttpClientHandler.xml --- xml/System.Net.Http/HttpClientHandler.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xml/System.Net.Http/HttpClientHandler.xml b/xml/System.Net.Http/HttpClientHandler.xml index 3eb758f2342..88c490549f2 100644 --- a/xml/System.Net.Http/HttpClientHandler.xml +++ b/xml/System.Net.Http/HttpClientHandler.xml @@ -486,7 +486,7 @@ On .NET Core, the key usage attribute on the X509 certificate, if present, is re property has been setted to `true` then, it has side effect on this property, and this property will be setted to . + If property has been set to `true` then, it has a side effect on this property, and this property will be set to . ]]> @@ -1458,7 +1458,7 @@ handler.ServerCertificateCustomValidationCallback = HttpClientHandler.DangerousA This property doesn't affect proxy credentials. When the default (system) proxy is being used, set credentials explicitly by using the property. When the proxy is set by the property, set credentials for the proxy via its property. - If this property has been setted to `true` then, it has side effect on property, and will be setted to . + If this property has been set to `true` then, it has a side effect on property, and will be set to . ]]> From c269ec421564e2bd08bab267195d71f5eb912a92 Mon Sep 17 00:00:00 2001 From: Ahmet Ibrahim Aksoy Date: Thu, 5 Oct 2023 07:21:09 +0200 Subject: [PATCH 3/3] Update xml/System.Net.Http/HttpClientHandler.xml Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com> --- xml/System.Net.Http/HttpClientHandler.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xml/System.Net.Http/HttpClientHandler.xml b/xml/System.Net.Http/HttpClientHandler.xml index 88c490549f2..6616b1e3f7e 100644 --- a/xml/System.Net.Http/HttpClientHandler.xml +++ b/xml/System.Net.Http/HttpClientHandler.xml @@ -486,7 +486,8 @@ On .NET Core, the key usage attribute on the X509 certificate, if present, is re property has been set to `true` then, it has a side effect on this property, and this property will be set to . + +If the property has been set to `true`, it has a side effect on this property, and this property will be set to . ]]>