[ci] Don't emit warnings for normal CheckAdbTarget operations.

Author: jpobst

build-tools/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks/Adb.cs

@@ -21,6 +21,7 @@ protected class CommandInfo
 			public Func<string> ArgumentsGenerator   { get; set; }
 			public bool         MergeStdoutAndStderr { get; set; } = true;
 			public bool         IgnoreExitCode       { get; set; }
+			public bool         LogIgnoredExitCodeAsWarning { get; set; } = true;
 			public string       StdoutFilePath       { get; set; }
 			public bool         StdoutAppend         { get; set; }
 			public string       StderrFilePath       { get; set; }
@@ -88,7 +89,11 @@ public override bool Execute ()
 						Log.LogError (message);
 						break;
 					}
-					Log.LogWarning (message);
+
+					if (info.LogIgnoredExitCodeAsWarning)
+						Log.LogWarning (message);
+					else
+						Log.LogMessage (MessageImportance.Normal, message);
 				} catch {
 					throw;
 				} finally {

build-tools/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks/CheckAdbTarget.cs

@@ -31,6 +31,9 @@ public class CheckAdbTarget : Adb
 
 		public override bool Execute ()
 		{
+			// Log messages as output rather than warnings
+			WriteOutputAsMessage = true;
+
 			base.Execute ();
 
 			// We always succeed
@@ -43,12 +46,14 @@ public override bool Execute ()
 				new CommandInfo {
 					ArgumentsString = $"{AdbTarget} shell getprop ro.build.version.sdk",
 					IgnoreExitCode = true,
+					LogIgnoredExitCodeAsWarning = false,
 					MergeStdoutAndStderr = false,
 				},
 
 				new CommandInfo {
 					ArgumentsString = $"{AdbTarget} shell pm path com.android.shell",
 					IgnoreExitCode = true,
+					LogIgnoredExitCodeAsWarning = false,
 					MergeStdoutAndStderr = false,
 					ShouldRun = () => IsValidTarget
 				},