Skip to content

35781 create new endpoint to save style editor schema per content type#36070

Draft
dario-daza wants to merge 3 commits into
mainfrom
35781-create-new-endpoint-to-save-style-editor-schema-per-content-type
Draft

35781 create new endpoint to save style editor schema per content type#36070
dario-daza wants to merge 3 commits into
mainfrom
35781-create-new-endpoint-to-save-style-editor-schema-per-content-type

Conversation

@dario-daza

@dario-daza dario-daza commented Jun 9, 2026

Copy link
Copy Markdown
Member

Proposed Changes

  • change 1
  • change 2

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

** any additional useful context or info **

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

This PR fixes: #35781

@claude

claude Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @dario-daza's task in 1m 52s —— View job


Rollback Safety Analysis

  • Read rollback-unsafe categories reference
  • Get full PR diff
  • Analyze diff against unsafe categories
  • Post results and apply label

Result: ✅ Safe To Rollback

After analyzing all changed files against the rollback-unsafe categories, no unsafe patterns were found.

Files Changed

File Category Check Verdict
ContentTypeResource.java New PATCH endpoint added (/v1/contenttype/id/{idOrVar}/metadata) ✅ Additive only — no existing endpoints modified
openapi.yaml New endpoint path added ✅ Auto-generated; only additive
WorkflowResource.java Collectors.toList().toList() refactor ✅ No behavioral change
dot-style-editor-builder.component.ts Angular frontend refactor ✅ UI-only change
dot-style-editor-builder.component.spec.ts Tests only ✅ No production impact
ContentTypeResourceUpdateMetadataTest.java Integration tests (new file) ✅ Test-only
Define_Contentlets_StyleProperties.postman_collection.json Postman tests updated ✅ Test-only

Category Walkthrough

  • C-1 (Structural Data Model Change): No runonce migration tasks. No changes to contentlet, identifier, inode, or related core tables. The new endpoint only modifies the existing metadata map on a ContentType via the existing ContentTypeAPI.save() path — no schema change.
  • C-2 (ES Mapping Change): No changes to ESMappingAPIImpl, ESMappingUtilHelper, or ESMappingConstants.
  • C-3 (Content JSON Model Version Bump): No changes to CURRENT_MODEL_VERSION or ImmutableContentlet.
  • C-4 (DROP TABLE/COLUMN): No DDL drop statements anywhere.
  • H-1 through H-7: No data migrations, renames, PK restructuring, new field types, storage provider changes, or NOT NULL column additions.
  • M-1 (Column Type Change): No DDL at all.
  • M-2 (Push Publishing Bundle): No bundle XML changes.
  • M-3 (API Contract Change): The new PATCH /v1/contenttype/id/{idOrVar}/metadata endpoint is purely additive — no existing endpoints were renamed, removed, or had their response shape changed. Rolling back to N-1 simply makes this endpoint unavailable (404), which has no impact on existing clients.
  • M-4 (OSGi Interface Change): No public interface or service registration changes.

Label AI: Safe To Rollback has been applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI: Safe To Rollback Area : Backend PR changes Java/Maven backend code Area : Frontend PR changes Angular/TypeScript frontend code

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

[Style Editor] - Updating/Creating Style Editor Schema for Content Type Silently Deletes Assigned Workflow

1 participant