Skip to content

Commit baabb79

Browse files
committed
use default resource
We already set os.SetEnv("OTEL_SERVICE_NAME", cmd.Name()) if it's not set, so don't have to do the merge here. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1 parent 8ed0480 commit baabb79

1 file changed

Lines changed: 1 addition & 15 deletions

File tree

cmd/docker/docker.go

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import (
2626
"github.com/spf13/pflag"
2727
"go.opentelemetry.io/contrib/exporters/autoexport"
2828
"go.opentelemetry.io/otel"
29-
"go.opentelemetry.io/otel/attribute"
3029
"go.opentelemetry.io/otel/propagation"
3130
"go.opentelemetry.io/otel/sdk/resource"
3231
sdktrace "go.opentelemetry.io/otel/sdk/trace"
@@ -362,20 +361,7 @@ func initializeTracing() error {
362361
}
363362
sp := sdktrace.NewBatchSpanProcessor(exporter)
364363

365-
// create a default resource but specify the service name explicitly, or
366-
// it will be `unknown_service:<name_of_exe>`
367-
//
368-
// N.B. a schemaless resource is used with the STABLE semconv value of
369-
// `service.name` to avoid https://github.com/open-telemetry/opentelemetry-go/issues/2341
370-
res, err := resource.Merge(
371-
resource.Default(),
372-
resource.NewSchemaless(
373-
attribute.String("service.name", "docker-cli"),
374-
),
375-
)
376-
if err != nil {
377-
return fmt.Errorf("merging resource: %w", err)
378-
}
364+
res := resource.Default()
379365

380366
tp := sdktrace.NewTracerProvider(
381367
sdktrace.WithSpanProcessor(sp),

0 commit comments

Comments
 (0)