From 7dbc4eed672b26924639472b9de11b3a1d676090 Mon Sep 17 00:00:00 2001 From: Brian Broll Date: Fri, 17 Aug 2018 18:22:29 -0500 Subject: [PATCH] Added extra guards for viz usage w/ default layout. --- src/visualizers/panels/PipelineIndex/PipelineIndexControl.js | 5 ++++- .../OperationInterfaceEditorWidget.js | 4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/visualizers/panels/PipelineIndex/PipelineIndexControl.js b/src/visualizers/panels/PipelineIndex/PipelineIndexControl.js index 45c42c030..bd8ddca04 100644 --- a/src/visualizers/panels/PipelineIndex/PipelineIndexControl.js +++ b/src/visualizers/panels/PipelineIndex/PipelineIndexControl.js @@ -123,6 +123,9 @@ define([ base, desc; + const executionCount = node.getSetNames().includes('executions') ? + node.getMemberIds('executions').length : 0; + if (node) { base = this._client.getNode(node.getBaseId()); desc = { @@ -131,7 +134,7 @@ define([ parentId: node.getParentId(), thumbnail: node.getAttribute('thumbnail'), type: base.getAttribute('name'), - executionCount: node.getMemberIds('executions').length + executionCount: executionCount }; } diff --git a/src/visualizers/widgets/OperationInterfaceEditor/OperationInterfaceEditorWidget.js b/src/visualizers/widgets/OperationInterfaceEditor/OperationInterfaceEditorWidget.js index ab0b355d4..77d28487d 100644 --- a/src/visualizers/widgets/OperationInterfaceEditor/OperationInterfaceEditorWidget.js +++ b/src/visualizers/widgets/OperationInterfaceEditor/OperationInterfaceEditorWidget.js @@ -125,7 +125,9 @@ define([ EasyDAG.prototype.addConnection.call(this, desc); // Remove connection selection var conn = this.connections[desc.id]; - conn.$el.on('click', null); + if (conn) { + conn.$el.on('click', null); + } }; // Hover buttons