Skip to content

feat: add insertRule batching optimization#21

Merged
jaredLunde merged 3 commits intomainfrom
fastdom
Sep 1, 2022
Merged

feat: add insertRule batching optimization#21
jaredLunde merged 3 commits intomainfrom
fastdom

Conversation

@jaredLunde
Copy link
Member

No description provided.

@jaredLunde jaredLunde self-assigned this Sep 1, 2022
| stylisPlugins | `Plugable[]` | No | | An array of Stylis plugins. See: https://www.npmjs.com/package/stylis |
| prefix | `boolean \| ((key: string, value: any, context: any) => boolean)` | No | `true` | Turns on/off vendor prefixing. When a boolean, all prefixes will be turned on/off. Use a function to define your own prefixes for a given key/value. |
| container | `HTMLElement` | No | `document.head` | This is the container that `<style>` tags will be injected into when style rules are inserted. |
| speedy | `boolean` | No | `true` in prod | Uses speedy mode for `<style>` tag insertion. It's the fastest way to insert new style rules, but will make styles uneditable via dev tools in some browsers. |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should add batchInserts here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's undocumented on purpose right now because experimental

@codecov-commenter
Copy link

Codecov Report

Merging #21 (cb99097) into main (d327470) will decrease coverage by 2.28%.
The diff coverage is 63.63%.

❗ Current head cb99097 differs from pull request most recent head a6845b6. Consider uploading reports for the commit a6845b6 to get more accurate results

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   98.03%   95.75%   -2.29%     
==========================================
  Files           5        5              
  Lines         357      353       -4     
  Branches      112      107       -5     
==========================================
- Hits          350      338      -12     
- Misses          7       15       +8     
Impacted Files Coverage Δ
src/create-styles.ts 98.89% <ø> (ø)
src/create-dash.ts 90.80% <63.63%> (-9.20%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jaredLunde jaredLunde merged commit d460435 into main Sep 1, 2022
@jaredLunde jaredLunde deleted the fastdom branch September 1, 2022 17:21
github-actions bot pushed a commit that referenced this pull request Sep 1, 2022
# [1.1.0](v1.0.2...v1.1.0) (2022-09-01)

### Features

* add insertRule batching optimization ([#21](#21)) ([d460435](d460435))
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants