🩼 fix: Keep OpenRouter Category Override Test Type-Safe - #16229
Merged
Merged
Conversation
Contributor
Author
|
Review handoff for head |
KinseyD
pushed a commit
to KinseyD/LibreChat
that referenced
this pull request
Sep 24, 2026
…#16229) Co-authored-by: Lia <lia@librechat.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The OpenRouter category attribution change in #16228 merged before its TypeScript CI check finished. That check then failed with TS7053 because the new override test indexes
configOptions.defaultHeadersas though it were always a plain record, but its type also allowsHeadersand header tuples. Check the same exact override using Jest's object matcher so the workspace typechecks without changing runtime attribution or the test's intended assertion.How it works
Change Type
Testing
node scripts/static-checks.mts --against origin/dev --only prettier,importsgit diff origin/dev...HEAD --checknode_modulesis missing dependencies and@typesdefinitions.Test Configuration:
Checklist