Skip to content

๐Ÿ—œ๏ธ fix: Support Windows ZIP MIME Uploads - #13794

Merged
danny-avila merged 1 commit into
devfrom
danny-avila/fix-windows-zip-mime
Jun 16, 2026
Merged

danny-avila merged 1 commit into
devfrom
danny-avila/fix-windows-zip-mime

Conversation

@danny-avila

@danny-avila danny-avila commented Jun 16, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

I fixed ZIP uploads for Code Interpreter across Windows browser MIME aliases and empty multipart MIME metadata.

  • Added application/x-zip-compressed to the shared full and Code Interpreter MIME allowlists.
  • Normalized application/x-zip-compressed to application/zip before client-side upload validation.
  • Reused shared filename-based MIME inference in the backend Multer upload filter so direct multipart uploads with an empty ZIP MIME are canonicalized before validation and downstream processing.
  • Covered shared MIME inference, client validation, and backend upload filtering with focused regression tests.

Fixes #13785

Change Type

  • Bug fix (non-breaking change which fixes an issue)

Testing

  • Ran git diff --check
  • npx jest src/file-config.spec.ts specs/filetypes.spec.ts --runInBand from packages/data-provider could not run locally because this worktree has no installed dependencies; Jest reported missing jest-junit.
  • npx jest src/utils/__tests__/validateFiles.spec.ts --runInBand from client could not run locally because this worktree has no installed dependencies; Jest reported missing jest-environment-jsdom.

Test Configuration:

  • Local worktree: /Users/danny/.codex/worktrees/0464/LibreChat
  • Node modules were not installed in this worktree.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 0f1f5a4c33

โ„น๏ธ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with ๐Ÿ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila marked this pull request as ready for review June 16, 2026 14:55
@danny-avila
danny-avila changed the base branch from main to dev June 16, 2026 14:55
@danny-avila
danny-avila force-pushed the danny-avila/fix-windows-zip-mime branch from 0f1f5a4 to 6772b8b Compare June 16, 2026 14:57

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 6772b8bb12

โ„น๏ธ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with ๐Ÿ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@danny-avila
danny-avila marked this pull request as draft June 16, 2026 15:11
@danny-avila
danny-avila marked this pull request as ready for review June 16, 2026 15:18
@danny-avila
danny-avila merged commit d0f659f into dev Jun 16, 2026
31 checks passed
@danny-avila
danny-avila deleted the danny-avila/fix-windows-zip-mime branch June 16, 2026 15:19
fuuuzzy pushed a commit to fuuuzzy/LibreChat that referenced this pull request Jun 18, 2026
ThomasVuNguyen pushed a commit to ThomasVuNguyen/LibreChat that referenced this pull request Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Zip file are not being added to Code Interpreter (but tar yes)

1 participant