From 71b567b0bc047d5f84b7fd0c3a7c6bbd9afd1b3d Mon Sep 17 00:00:00 2001 From: sshane Date: Sun, 26 Mar 2023 23:15:03 -0700 Subject: [PATCH 1/7] shuffle around --- car.capnp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/car.capnp b/car.capnp index 72315f917..25697c83c 100644 --- a/car.capnp +++ b/car.capnp @@ -632,10 +632,10 @@ struct CarParams { adas @19; cornerRadar @21; hvac @20; + parking @7; # parking assist system ecu (IPAS/RSPA/APGS) # Toyota only dsu @6; - apgs @7; # Honda only vsa @13; # Vehicle Stability Assist @@ -645,9 +645,9 @@ struct CarParams { hcp @18; # Hybrid Control Processor # Hyundai only - parking @22; # ADAS parking ECU debug @17; + unused @22; } enum FingerprintSource { From 7698fc0b19950ff2817029a37998167675c4d711 Mon Sep 17 00:00:00 2001 From: sshane Date: Sun, 26 Mar 2023 23:16:51 -0700 Subject: [PATCH 2/7] ECU --- car.capnp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/car.capnp b/car.capnp index 25697c83c..c0feb4217 100644 --- a/car.capnp +++ b/car.capnp @@ -632,7 +632,7 @@ struct CarParams { adas @19; cornerRadar @21; hvac @20; - parking @7; # parking assist system ecu (IPAS/RSPA/APGS) + parking @7; # parking assist system ECU (IPAS/RSPA/APGS) # Toyota only dsu @6; From 5023925db3745c199442897ed96c9b265cda56bb Mon Sep 17 00:00:00 2001 From: sshane Date: Sun, 26 Mar 2023 23:17:13 -0700 Subject: [PATCH 3/7] no hyundai --- car.capnp | 2 -- 1 file changed, 2 deletions(-) diff --git a/car.capnp b/car.capnp index c0feb4217..46c3db285 100644 --- a/car.capnp +++ b/car.capnp @@ -644,8 +644,6 @@ struct CarParams { # Chrysler only hcp @18; # Hybrid Control Processor - # Hyundai only - debug @17; unused @22; } From b5e099aebe17e12ea13d254ae61c6098bac51660 Mon Sep 17 00:00:00 2001 From: sshane Date: Sun, 26 Mar 2023 23:18:25 -0700 Subject: [PATCH 4/7] can remove --- car.capnp | 1 - 1 file changed, 1 deletion(-) diff --git a/car.capnp b/car.capnp index 46c3db285..db11aa05b 100644 --- a/car.capnp +++ b/car.capnp @@ -645,7 +645,6 @@ struct CarParams { hcp @18; # Hybrid Control Processor debug @17; - unused @22; } enum FingerprintSource { From a9f39d53893abb550b912c6167c9a9626de58fb6 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Mon, 27 Mar 2023 10:56:21 -0700 Subject: [PATCH 5/7] add unused ecu --- car.capnp | 1 + 1 file changed, 1 insertion(+) diff --git a/car.capnp b/car.capnp index db11aa05b..46c3db285 100644 --- a/car.capnp +++ b/car.capnp @@ -645,6 +645,7 @@ struct CarParams { hcp @18; # Hybrid Control Processor debug @17; + unused @22; } enum FingerprintSource { From 458e81d88ae6d65f3331987f03431e01d61a7597 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Mon, 27 Mar 2023 10:56:51 -0700 Subject: [PATCH 6/7] Update car.capnp Co-authored-by: Adeeb Shihadeh --- car.capnp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/car.capnp b/car.capnp index 46c3db285..7d45511fb 100644 --- a/car.capnp +++ b/car.capnp @@ -632,7 +632,7 @@ struct CarParams { adas @19; cornerRadar @21; hvac @20; - parking @7; # parking assist system ECU (IPAS/RSPA/APGS) + parkingADAS @7; # parking assist system ECU, e.g. Toyota's IPAS, Hyundai's RSPA, etc. # Toyota only dsu @6; From 7d0cbd1c464f260d5dc50f9fb778a5b9757bcce1 Mon Sep 17 00:00:00 2001 From: Shane Smiskol Date: Mon, 27 Mar 2023 11:49:50 -0700 Subject: [PATCH 7/7] follow convention --- car.capnp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/car.capnp b/car.capnp index 7d45511fb..7b232af96 100644 --- a/car.capnp +++ b/car.capnp @@ -632,7 +632,7 @@ struct CarParams { adas @19; cornerRadar @21; hvac @20; - parkingADAS @7; # parking assist system ECU, e.g. Toyota's IPAS, Hyundai's RSPA, etc. + parkingAdas @7; # parking assist system ECU, e.g. Toyota's IPAS, Hyundai's RSPA, etc. # Toyota only dsu @6;