Repository navigation
Fix sub-agent bootstrap from WebSocket messages - #1425
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: e8a8760 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
agents
@cloudflare/ai-chat
@cloudflare/codemode
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
Made-with: Cursor
Made-with: Cursor
threepointone
force-pushed
the
fix/sub-agent-websocket-facet-bootstrap
branch
from
April 30, 2026 13:17
1d59b35 to
e8a8760
Compare
Merged
3 tasks done
threepointone
added a commit
that referenced
this pull request
Jun 4, 2026
…rd (#1680) The `_suppressProtocolBroadcasts` flag was added in #1425 to stop `_broadcastProtocol()` from enumerating the parent DO's WebSockets during facet bootstrap (the cross-DO Native I/O crash, #1410/#1677). The proper fix in #1679 makes this unnecessary: on a facet, `getConnections()` returns only virtual sub-agent connections and `broadcast()` routes through the parent bridge, so `_broadcastProtocol()` can no longer touch the parent's own sockets — during bootstrap or otherwise. Removing the flag also lets legitimate state sync run during the bootstrap window. Verified in production (raw #1410 repro): with the flag removed, both the HTTP control path and the WebSocket path (spawn sub-agent from `onMessage`) return ok:true. Also removes the now-obsolete `wip/issue-1410-reporter-repro` fixture (issue fully resolved by #1679; verified in prod before removal). The separate request/WebSocket/email native-handle clearing from #1425 is retained. It is not what fixes #1410 — verified that a child facet never inherits the parent's connection across the facet RPC boundary even without it — but it is kept as low-cost, correct context hygiene for cross-Agent calls (covering request/email/general cases #1679 does not touch).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onMessageand for state sync to clients connected directly to a sub-agent._cf_initAsFacetthrows "Cannot perform I/O on behalf of a different Durable Object" on firstthis.nameread after the #1393 / 0.11.6 fix #1410.Test plan
npx vitest --project workers --run src/tests/sub-agent.test.tsnpx oxfmt --check packages/agents/src/index.ts packages/agents/src/tests/sub-agent.test.ts packages/agents/src/tests/agents/sub-agent.ts wip/issue-1410-reporter-repro/src/index.ts wip/issue-1410-reporter-repro/wrangler.jsonc wip/issue-1410-reporter-repro/package.json wip/issue-1410-reporter-repro/tsconfig.json wip/issue-1410-reporter-repro/README.md .changeset/native-context-facet-bootstrap.mdwip/issue-1410-reporter-reproand verified both/http-spawnand/wsreturnok: truein production with scoped bootstrap suppression.