From bb73095980a646d0cf14636613e927d0b811ea8c Mon Sep 17 00:00:00 2001 From: wobsoriano Date: Wed, 3 Sep 2025 12:47:34 -0700 Subject: [PATCH 1/3] chore(localizations): Add missing titleCombined translation for zh-TW --- packages/clerk-js/src/ui/contexts/components/UserButton.ts | 2 +- packages/localizations/src/zh-TW.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/clerk-js/src/ui/contexts/components/UserButton.ts b/packages/clerk-js/src/ui/contexts/components/UserButton.ts index 0ac80564a0a..6ec65dd6472 100644 --- a/packages/clerk-js/src/ui/contexts/components/UserButton.ts +++ b/packages/clerk-js/src/ui/contexts/components/UserButton.ts @@ -50,7 +50,7 @@ export const useUserButtonContext = () => { const menuItems = useMemo(() => { return createUserButtonCustomMenuItems(customMenuItems || [], clerk); - }, []); + }, [customMenuItems, clerk]); return { ...ctx, diff --git a/packages/localizations/src/zh-TW.ts b/packages/localizations/src/zh-TW.ts index 6dad8aca16d..77705d8b585 100644 --- a/packages/localizations/src/zh-TW.ts +++ b/packages/localizations/src/zh-TW.ts @@ -695,7 +695,7 @@ export const zhTW: LocalizationResource = { subtitle: '以繼續前往 {{applicationName}}', subtitleCombined: undefined, title: '登入', - titleCombined: undefined, + titleCombined: '繼續前往 {{applicationName}}', }, totpMfa: { formTitle: '驗證碼', From f87f81de217278d1c0d8710c8232116be3295f06 Mon Sep 17 00:00:00 2001 From: wobsoriano Date: Wed, 3 Sep 2025 12:48:12 -0700 Subject: [PATCH 2/3] revert unused --- packages/clerk-js/src/ui/contexts/components/UserButton.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/clerk-js/src/ui/contexts/components/UserButton.ts b/packages/clerk-js/src/ui/contexts/components/UserButton.ts index 6ec65dd6472..0ac80564a0a 100644 --- a/packages/clerk-js/src/ui/contexts/components/UserButton.ts +++ b/packages/clerk-js/src/ui/contexts/components/UserButton.ts @@ -50,7 +50,7 @@ export const useUserButtonContext = () => { const menuItems = useMemo(() => { return createUserButtonCustomMenuItems(customMenuItems || [], clerk); - }, [customMenuItems, clerk]); + }, []); return { ...ctx, From e0c89f4a4b2cfd8d56d8e8b14336ffdb4cd99cf3 Mon Sep 17 00:00:00 2001 From: Robert Soriano Date: Wed, 3 Sep 2025 12:54:49 -0700 Subject: [PATCH 3/3] chore: add changeset --- .changeset/breezy-coins-heal.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/breezy-coins-heal.md diff --git a/.changeset/breezy-coins-heal.md b/.changeset/breezy-coins-heal.md new file mode 100644 index 00000000000..deca613aa33 --- /dev/null +++ b/.changeset/breezy-coins-heal.md @@ -0,0 +1,5 @@ +--- +"@clerk/localizations": patch +--- + +Add Traditional Chinese translation for sign in or up combined title