feat: replace old settings form with the new implementation

[tpoisseau]

Closes: #4032
Closes: #3932

[cloudflare-workers-and-pages]

Deploying nmrium with    Cloudflare Pages

Latest commit:	bea3a26
Status:	✅  Deploy successful!
Preview URL:	https://f7d70c0e.nmrium.pages.dev
Branch Preview URL:	https://4032-replace-previous-generi.nmrium.pages.dev

View logs

[tpoisseau]

If you find any issues that were not present in the previous implementation, now is the time to report them. It needs to be fixed, before merge this PR.

If you find issues but they already here in previous implementation this should not block this PR and open a new issue.

[targos]

The "Reset workspace preferences" button's is not enabled based on the right condition. I guess it's based on the form being dirty, but it should be based on the workspace being dirty and reset to the last saved state of the workspace (or to the initial value for read-only workspaces)

[tpoisseau]

Ok, I re-checked the previous check. adapt and fixed.

  const isResetDisabled = useMemo(() => {
    if (!isPristine) return false;

    const original = getPreferencesByWorkspace(currentName, originalWorkspaces);

    return isEqualLodash(current, original);
  }, [current, currentName, isPristine, originalWorkspaces]);

Method with JSON.stringify is heavy and leads to false-positive. (sensible to property declaration order), isEqualLodash works better.

There is still an edge-case. If the form is not pristine but all values match with original: reset is allowed, but it will reset to the same values. I think it's OK, if not we could remove the first check.

[targos]

There is still an edge-case. If the form is not pristine but all values match with original: reset is allowed, but it will reset to the same values. I think it's OK, if not we could remove the first check.

That sounds OK, but then is there a way for it to become pristine when the click is done? It's confusing that the read-only workspace stays "unsaved" even after clicking on reset.

[targos]

To reproduce the case:

• Open the page fresh -> Simple NMR analysis workspace is loaded and pristine
• Open the settings
• Save the settings (without changes)
• Workspace is not pristine anymore (I can accept that, since the form maybe initialized some fields with default values)
• Open the settings
• Click the reset button -> Why is it not considered pristine now?

[tpoisseau]

left: current after save the form. right: original

I found the issue. The new form change the order of filters.

I'll fix that.

(reset set the form pristine, it changes the default values)

[targos]

Wow it's nice that we found it. It's a real bug (filter order is important)!

[tpoisseau]

I fixed it, (not yet pushed) but form save apply more props than workspaceDefaultProperties (the source of workspace normalization) so isEqual return false.
Ex: workspaceDefaultProperties.display.panels.matrixGenerationPanel does not exists. The form saves it. so comparaison is broken.

[tpoisseau]

When comparing form behavior, pay attention to the experimental mode. Check it add more fields in the form

[targos]

I'll finish the review with @lpatiny on Monday