From 4a099db2e07593f5c940724fa56b6dc3f43f3d21 Mon Sep 17 00:00:00 2001 From: Shevchik Igor Date: Mon, 31 Aug 2026 06:12:40 +0000 Subject: [PATCH 1/2] fix(playgrounds): add the InputMenu autocomplete-mode row both are missing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Upstream's `2799fa6f` — the commit that renamed InputMenu's `autocomplete` boolean to `mode: 'combobox' | 'autocomplete'` — added a row exercising the new mode to its own playground. The port (#68) dropped that line, and nothing has added one since, so the mode has never been reachable by hand in either playground: no snapshot covers it either, since the render is identical and only the prop spelling differs. The row needs its own ref rather than reusing one above it. In autocomplete mode `modelValue` is the input text, a string, where every other row on the page holds a selected item — which is the whole point of the mode and the thing a person is there to look at. Found by backfilling that commit's `.sync/log/` entry in #518, which is also where the omission is recorded; the log's "neither playground has one" is updated to say it was closed here. Gate: lint, typecheck (both playgrounds among the four projects it types), build (3.86 MB), test (322 files, 7502 passed). --- .../log/2799fa6f2b25ce3eb15e050f3ef7c57d0d9a2fdb.md | 12 +++++++----- .../demo/app/pages/components/input-menu.vue | 13 +++++++++++++ .../nuxt/app/pages/components/input-menu.vue | 13 +++++++++++++ 3 files changed, 33 insertions(+), 5 deletions(-) diff --git a/.sync/log/2799fa6f2b25ce3eb15e050f3ef7c57d0d9a2fdb.md b/.sync/log/2799fa6f2b25ce3eb15e050f3ef7c57d0d9a2fdb.md index eb36ac839..b35ae3947 100644 --- a/.sync/log/2799fa6f2b25ce3eb15e050f3ef7c57d0d9a2fdb.md +++ b/.sync/log/2799fa6f2b25ce3eb15e050f3ef7c57d0d9a2fdb.md @@ -60,13 +60,15 @@ Deliberately narrower than upstream in three places, two of which are right: contents (`autocomplete` → `mode="autocomplete"`) and kept the name, which keeps `name: 'input-menu-autocomplete-example'` in the docs page valid. Still the current state: the file is `InputMenuAutocompleteExample.vue` on `main`. -- **Playground line dropped, and this one is a gap.** Upstream added +- **Playground line dropped — a real gap, closed later.** Upstream added `` to `playgrounds/nuxt/app/pages/components/input-menu.vue`. Nothing equivalent was - added here, and re-checking at the time of writing, neither - `playgrounds/nuxt` nor `playgrounds/demo` has an autocomplete-mode row for - InputMenu. Small, but real: it is the only place the mode can be exercised by - hand, and the omission was not recorded anywhere until now. + added here, and when this log was first written neither `playgrounds/nuxt` nor + `playgrounds/demo` had an autocomplete-mode row for InputMenu — small, but the + only place the mode could be exercised by hand, and recorded nowhere until this + backfill turned it up. **Fixed on 2026-08-31 (#519):** both playgrounds now + carry the row, backed by its own `valueAutocomplete` ref, because in this mode + `modelValue` is the input text rather than a selected item. The native-attribute half of the change was ported and covered: diff --git a/playgrounds/demo/app/pages/components/input-menu.vue b/playgrounds/demo/app/pages/components/input-menu.vue index a7b6c8d66..22b863e18 100644 --- a/playgrounds/demo/app/pages/components/input-menu.vue +++ b/playgrounds/demo/app/pages/components/input-menu.vue @@ -34,6 +34,9 @@ const items = ref(['Prospecting', 'Qualifying', 'Presenting', 'Negotiating', 'Cl const itemsSimple = ref(['Prospecting', 'Qualifying', 'Presenting', 'Negotiating', 'Closed']) const valueForAdd = ref('Prospecting') const valueMultiple = ref(['Prospecting', 'Presenting']) +// `mode="autocomplete"` makes modelValue the input text rather than a selected +// item, so this one is a string where the rows above hold items. +const valueAutocomplete = ref('') // #342 is only visible with labels long enough to want more room than the field // has. happy-dom does no layout, so no snapshot can show this — the check is a @@ -234,6 +237,16 @@ const itemsObj = ref([ v-bind="{ ...singleAttrs, ...props }" class="w-full" /> + + Date: Mon, 31 Aug 2026 06:30:24 +0000 Subject: [PATCH 2/2] docs(sync): point the InputMenu log at the right PR The backfilled log's cross-reference was written before the PR existed and guessed #519; it is #520. A log that points at the wrong PR is the dead reference the pairing guard exists to prevent, one level up. --- .sync/log/2799fa6f2b25ce3eb15e050f3ef7c57d0d9a2fdb.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.sync/log/2799fa6f2b25ce3eb15e050f3ef7c57d0d9a2fdb.md b/.sync/log/2799fa6f2b25ce3eb15e050f3ef7c57d0d9a2fdb.md index b35ae3947..93fa7fe74 100644 --- a/.sync/log/2799fa6f2b25ce3eb15e050f3ef7c57d0d9a2fdb.md +++ b/.sync/log/2799fa6f2b25ce3eb15e050f3ef7c57d0d9a2fdb.md @@ -66,7 +66,7 @@ Deliberately narrower than upstream in three places, two of which are right: added here, and when this log was first written neither `playgrounds/nuxt` nor `playgrounds/demo` had an autocomplete-mode row for InputMenu — small, but the only place the mode could be exercised by hand, and recorded nowhere until this - backfill turned it up. **Fixed on 2026-08-31 (#519):** both playgrounds now + backfill turned it up. **Fixed on 2026-08-31 (#520):** both playgrounds now carry the row, backed by its own `valueAutocomplete` ref, because in this mode `modelValue` is the input text rather than a selected item.