test(agents): add naming clash test and fix for custom-filename collision

When an existing agent file uses a custom filename (e.g. custom_name.jsonc
for an agent named "support_agent"), and a new remote agent arrives whose
default filename matches that custom file, writeAgents now throws an error
instead of silently overwriting the first agent's file.

- Detects clash by tracking claimed file paths before writing new agents
- Adds with-agents-naming-clash fixture (custom_name.jsonc with name "support_agent")
- Adds CLI test asserting the command fails and mentions the clashing name

Co-authored-by: paveltarno <Paveltarno@users.noreply.github.com>

Author: github-actions[bot]

src/core/resources/agent/config.ts

@@ -94,6 +94,10 @@ export async function writeAgents(
     }
   }
 
+  const claimedPaths = new Set(
+    [...nameToEntry.values()].map((e) => e.filePath),
+  );
+
   const written: string[] = [];
   for (const agent of remoteAgents) {
     const existing = nameToEntry.get(agent.name);
@@ -102,9 +106,18 @@ export async function writeAgents(
       continue;
     }
 
-    const filePath =
-      existing?.filePath ??
-      join(agentsDir, `${agent.name}.${CONFIG_FILE_EXTENSION}`);
+    const defaultPath = join(
+      agentsDir,
+      `${agent.name}.${CONFIG_FILE_EXTENSION}`,
+    );
+
+    if (!existing && claimedPaths.has(defaultPath)) {
+      throw new Error(
+        `Cannot write agent "${agent.name}": file "${defaultPath}" is already used by another agent`,
+      );
+    }
+
+    const filePath = existing?.filePath ?? defaultPath;
     await writeJsonFile(filePath, agent);
     written.push(agent.name);
   }

tests/cli/agents_pull.spec.ts

@@ -106,6 +106,33 @@ describe("agents pull command", () => {
     expect(fileContent).toContain("// My support agent");
   });
 
+  it("fails when a new remote agent's default filename clashes with an existing custom-named file", async () => {
+    // Local: custom_name.jsonc has name "support_agent" (custom filename)
+    // Remote returns support_agent (maps to custom_name.jsonc) AND custom_name
+    // (new agent whose default path custom_name.jsonc is already taken)
+    await t.givenLoggedInWithProject(fixture("with-agents-naming-clash"));
+    t.api.mockAgentsFetch({
+      items: [
+        {
+          name: "support_agent",
+          description: "Helps users",
+          instructions: "Be helpful",
+        },
+        {
+          name: "custom_name",
+          description: "A new agent",
+          instructions: "Do new things",
+        },
+      ],
+      total: 2,
+    });
+
+    const result = await t.run("agents", "pull");
+
+    t.expectResult(result).toFail();
+    t.expectResult(result).toContain("custom_name");
+  });
+
   it("updates agent file in-place when remote data changes", async () => {
     await t.givenLoggedInWithProject(fixture("with-agents-for-pull"));
     t.api.mockAgentsFetch({

tests/fixtures/with-agents-naming-clash/base44/.app.jsonc

@@ -0,0 +1,3 @@
+{
+  "id": "test-app-id"
+}

tests/fixtures/with-agents-naming-clash/base44/agents/custom_name.jsonc

@@ -0,0 +1,6 @@
+// Agent stored with a custom filename (not matching its name slug)
+{
+  "name": "support_agent",
+  "description": "Helps users",
+  "instructions": "Be helpful"
+}

tests/fixtures/with-agents-naming-clash/base44/config.jsonc

@@ -0,0 +1,3 @@
+{
+  "name": "Agents Naming Clash Test Project"
+}