Skip to content

ci: bump Redline to askalf/ci@9a559dc - #159

Merged
askalf merged 2 commits into
mainfrom
bot/redline-pin
Oct 17, 2026
Merged

askalf merged 2 commits into
mainfrom
bot/redline-pin

Conversation

@askalf

@askalf askalf commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Moves the two pinned askalf/ci reusable-workflow calls (redline-review.yml in redline.yml and redline-fix-run.yml in redline-fix.yml) and their redline-ref inputs to askalf/ci@9a559dc, the main commit that last changed the review, the fix or the report step (main 2026-10-17, askalf/ci#62). The scripts are fetched at that same commit. The pins are the only change.

@github-actions github-actions Bot added github_actions Pull requests that update GitHub Actions code size/XS Under 10 hand-written lines labels Oct 17, 2026
@askalf
askalf enabled auto-merge (squash) October 17, 2026 03:32

@sprayberry-redline sprayberry-redline left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: request changes. Request changes because the pull request description says it updates drift-report action pins, but the diff changes only the two Redline reusable-workflow references and their inputs.

1. Blocking: PR description:1

Moves the pinned askalf/ci calls and their redline-ref inputs, and every drift-report action pin, to askalf/ci@9a559dc, the main commit that last changed the review, the fix or the report step (main 2026-10-17, askalf/ci#62). The scripts are fetched at that same commit. The pins are the only change.

This narrates updates to "every drift-report action pin," but neither changed workflow contains a drift-report action and the diff changes only the review and fix reusable-workflow pins plus their redline-ref values. The public description therefore claims a broader change than the patch makes.

Suggested fix:

Revise the description to state only the two reusable-workflow and redline-ref pin updates actually present, or include the claimed drift-report pin changes.

rule:reads-as-generated

@askalf

askalf commented Oct 17, 2026

Copy link
Copy Markdown
Owner Author

Description updated at b5606a8

  • [1] PR description: removed the claim that drift-report action pins were updated. Neither workflow in this repository contains a drift-report action. The description now names only the changes in the diff: the redline-review.yml call in redline.yml and the redline-fix-run.yml call in redline-fix.yml, plus their redline-ref inputs, all pinned to askalf/ci@9a559dc. No code changed.

The pull request description is replaced.

No file changed.

@sprayberry-redline sprayberry-redline left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: approve. The reusable review and fix workflows remain pinned to the same full commit passed as redline-ref, so both workflow execution and script retrieval advance together.

@askalf
askalf merged commit d4de609 into main Oct 17, 2026
14 of 15 checks passed
@askalf
askalf deleted the bot/redline-pin branch October 17, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/XS Under 10 hand-written lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants