Skip to content

Adopt ArgumentParser for the command-line tool#72

Closed
natecook1000 wants to merge 2 commits into
swiftlang:masterfrom
natecook1000:argumentparser
Closed

Adopt ArgumentParser for the command-line tool#72
natecook1000 wants to merge 2 commits into
swiftlang:masterfrom
natecook1000:argumentparser

Conversation

@natecook1000

Copy link
Copy Markdown
Member

This adopts the new ArgumentParser library for parsing command-line arguments.

@benlangmuir

Copy link
Copy Markdown
Contributor

Hey @natecook1000 this looks really nice. My preference would be to wait until SwiftPM adopts ArgumentParser, then adopt it in sourcekit-lsp and indexstore-db. Until we're using it across the board in sourcekit-lsp+swiftpm, introducing a new dependency creates integration headaches for us that outweigh the benefits in this case (since this is only a tiny test executable).

I'd be happy to keep this PR open until we're ready to take it. Thanks again for the PR

@natecook1000

Copy link
Copy Markdown
Member Author

@benlangmuir Sounds like a good plan! I'll ping back when we've landed the SwiftPM change.

@shahmishal shahmishal closed this Oct 6, 2020
@shahmishal

Copy link
Copy Markdown
Member

The Swift project moved the default branch to main and deleted master branch, so GitHub automatically closed the PR. Please re-create the pull request with main branch.

More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants