Skip to content

Commit c74950d

Browse files
authored
Revert "chore: tune release packages (#856)"
This reverts commit aa0765e.
1 parent 6454758 commit c74950d

3 files changed

Lines changed: 36 additions & 29 deletions

File tree

.github/workflows/publish.js.yml

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@ jobs:
1414

1515
env:
1616
XCODE_VERSION: 14.3.1
17+
ZIP_PKG_NAME_IOS: "WebDriverAgentRunner-Runner.zip"
1718
PKG_PATH_IOS: "appium_wda_ios"
19+
ZIP_PKG_NAME_TVOS: "WebDriverAgentRunner_tvOS-Runner.zip"
1820
PKG_PATH_TVOS: "appium_wda_tvos"
1921

2022
steps:
@@ -33,7 +35,7 @@ jobs:
3335
- run: npm run test
3436
name: Run test
3537

36-
# building WDA packages to test package build
38+
# building WDA packages
3739
- name: Build iOS
3840
run: |
3941
xcodebuild clean build-for-testing \
@@ -42,6 +44,13 @@ jobs:
4244
-scheme WebDriverAgentRunner \
4345
-destination generic/platform=iOS \
4446
CODE_SIGNING_ALLOWED=NO ARCHS=arm64
47+
- name: Creating a zip of WebDriverAgentRunner-Runner.app for iOS after removing test frameworks
48+
run: |
49+
pushd appium_wda_ios/Build/Products/Debug-iphoneos
50+
rm -rf WebDriverAgentRunner-Runner.app/Frameworks/XC*.framework
51+
zip -r $ZIP_PKG_NAME_IOS WebDriverAgentRunner-Runner.app
52+
popd
53+
mv $PKG_PATH_IOS/Build/Products/Debug-iphoneos/$ZIP_PKG_NAME_IOS ./
4554
- name: Build tvOS
4655
run: |
4756
xcodebuild clean build-for-testing \
@@ -50,10 +59,18 @@ jobs:
5059
-scheme WebDriverAgentRunner_tvOS \
5160
-destination generic/platform=tvOS \
5261
CODE_SIGNING_ALLOWED=NO ARCHS=arm64
62+
- name: Creating a zip of WebDriverAgentRunner-Runner.app for tvOS after removing test frameworks
63+
run: |
64+
pushd appium_wda_tvos/Build/Products/Debug-appletvos
65+
rm -rf WebDriverAgentRunner_tvOS-Runner.app/Frameworks/XC*.framework
66+
zip -r $ZIP_PKG_NAME_TVOS WebDriverAgentRunner_tvOS-Runner.app
67+
popd
68+
mv $PKG_PATH_TVOS/Build/Products/Debug-appletvos/$ZIP_PKG_NAME_TVOS ./
5369
5470
# release tasks
5571
- run: npx semantic-release
5672
env:
5773
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5874
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
5975
name: Release
76+

.github/workflows/wda-package.yml

Lines changed: 13 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@ name: Building WebDriverAgent
22

33
on:
44
workflow_dispatch:
5-
release:
6-
types: [published]
5+
workflow_run:
6+
workflows: ["Release"]
7+
types:
8+
- completed
79

810
env:
911
HOST: macos-13
@@ -54,25 +56,14 @@ jobs:
5456
WD: appium_wda_tvos/Build/Products/Debug-appletvos
5557
ZIP_PKG_NAME: "${{ env.ZIP_PKG_NAME_TVOS }}"
5658

57-
- name: upload WebDriverAgentRunner-Runner.zip
58-
uses: actions/upload-release-asset@v1
59-
env:
60-
GITHUB_TOKEN: ${{ secrets.token }}
59+
- name: Upload the built generic app package for iOS
60+
uses: actions/upload-artifact@v3.1.0
6161
with:
62-
upload_url: ${{ github.event.release.upload_url }}
63-
asset_path: "${{ env.ZIP_PKG_NAME_IOS }}"
64-
asset_name: WebDriverAgentRunner-Runner.zip
65-
asset_content_type: application/zip
66-
67-
- name: upload WebDriverAgentRunner_tvOS-Runner.zip
68-
uses: actions/upload-release-asset@v1
69-
env:
70-
GITHUB_TOKEN: ${{ secrets.token }}
62+
path: "${{ env.ZIP_PKG_NAME_IOS }}"
63+
- name: Upload the built generic app package for tvOS
64+
uses: actions/upload-artifact@v3.1.0
7165
with:
72-
upload_url: ${{ github.event.release.upload_url }}
73-
asset_path: ${{ env.ZIP_PKG_NAME_TVOS }}"
74-
asset_name: WebDriverAgentRunner_tvOS-Runner.zip
75-
asset_content_type: application/zip
66+
path: "${{ env.ZIP_PKG_NAME_TVOS }}"
7667

7768
for_simulator_devices:
7869
needs: [host_machine]
@@ -98,12 +89,7 @@ jobs:
9889
SCHEME: WebDriverAgentRunner${{ matrix.target }}
9990
ARCHS: ${{ matrix.arch }}
10091
ZIP_PKG_NAME: "WebDriverAgentRunner${{ matrix.target }}-Build-Sim-${{ matrix.arch }}.zip"
101-
- name: upload windows WebDriverAgentRunner${{ matrix.target }}-Build-Sim-${{ matrix.arch }}.zip
102-
uses: actions/upload-release-asset@v1
103-
env:
104-
GITHUB_TOKEN: ${{ secrets.token }}
92+
- name: Upload the built generic app package for WebDriverAgentRunner${{ matrix.target }} with ${{ matrix.arch }}
93+
uses: actions/upload-artifact@v3.1.0
10594
with:
106-
upload_url: ${{ github.event.release.upload_url }}
107-
asset_path: "WebDriverAgentRunner${{ matrix.target }}-Build-Sim-${{ matrix.arch }}.zip"
108-
asset_name: "WebDriverAgentRunner${{ matrix.target }}-Build-Sim-${{ matrix.arch }}.zip"
109-
asset_content_type: application/zip
95+
path: "WebDriverAgentRunner${{ matrix.target }}-Build-Sim-${{ matrix.arch }}.zip"

.releaserc

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@
3232
"assets": ["docs", "package.json", "CHANGELOG.md"],
3333
"message": "chore(release): ${nextRelease.version} [skip ci]\n\n${nextRelease.notes}"
3434
}],
35-
["@semantic-release/github"]
35+
["@semantic-release/github", {
36+
"assets": [
37+
"WebDriverAgentRunner-Runner.zip",
38+
"WebDriverAgentRunner_tvOS-Runner.zip"
39+
]}]
3640
]
3741
}

0 commit comments

Comments
 (0)