From c9d950878eb42a246c04d293bd9283942babbdeb Mon Sep 17 00:00:00 2001 From: Vince Broz Date: Sun, 6 Sep 2026 21:17:57 -0400 Subject: [PATCH 1/3] Fetch full history in Plugin workflow checkouts The regression, rails, and rspec jobs in plugins.yml run bundle exec rake spec, whose spec task unconditionally shells out to undercover, comparing against origin/master. Their actions/checkout@v3 step used the default shallow, single-ref fetch, so origin/master never existed locally and the undercover subprocess crashed with a Rugged::ReferenceError on every run of these jobs. rspec.yml already fetch-depth: 0 for its own dedicated undercover job, with a comment explaining why. Apply the same setting to the three plugins.yml jobs that hit the same comparison. --- .github/workflows/plugins.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/plugins.yml b/.github/workflows/plugins.yml index a2fce4747..06743811c 100644 --- a/.github/workflows/plugins.yml +++ b/.github/workflows/plugins.yml @@ -20,6 +20,10 @@ jobs: steps: - uses: actions/checkout@v3 + with: + # fetch all history for all branches and tags so we can + # compare against origin/master + fetch-depth: 0 - name: Set up Ruby uses: ruby/setup-ruby@v1 with: @@ -54,6 +58,10 @@ jobs: steps: - uses: actions/checkout@v3 + with: + # fetch all history for all branches and tags so we can + # compare against origin/master + fetch-depth: 0 - name: Set up Ruby uses: ruby/setup-ruby@v1 with: @@ -89,6 +97,10 @@ jobs: steps: - uses: actions/checkout@v3 + with: + # fetch all history for all branches and tags so we can + # compare against origin/master + fetch-depth: 0 - name: Set up Ruby uses: ruby/setup-ruby@v1 with: From 62d037493719d457bd956dd2f6263010461cb21f Mon Sep 17 00:00:00 2001 From: Vince Broz Date: Sun, 6 Sep 2026 21:27:09 -0400 Subject: [PATCH 2/3] Skip the embedded undercover check in Plugin jobs rake spec's embedded undercover call compares against origin/master, which does not apply to the regression, rails, and rspec jobs in plugins.yml -- they test solargraph against a plugin combination, not a diff against master. Run rake full_spec instead, which runs the same rspec suite without that comparison. This drops the fetch-depth: 0 checkout change from the previous commit on this branch, which is no longer needed once undercover is not invoked here at all. --- .github/workflows/plugins.yml | 21 ++++++--------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/.github/workflows/plugins.yml b/.github/workflows/plugins.yml index 06743811c..02abd50bd 100644 --- a/.github/workflows/plugins.yml +++ b/.github/workflows/plugins.yml @@ -20,10 +20,6 @@ jobs: steps: - uses: actions/checkout@v3 - with: - # fetch all history for all branches and tags so we can - # compare against origin/master - fetch-depth: 0 - name: Set up Ruby uses: ruby/setup-ruby@v1 with: @@ -52,16 +48,13 @@ jobs: # @todo Temporary, expect to revert in 0.60 continue-on-error: true - name: Ensure specs still run - run: bundle exec rake spec + # full_spec, not spec: skip the embedded undercover check + run: bundle exec rake full_spec rails: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - with: - # fetch all history for all branches and tags so we can - # compare against origin/master - fetch-depth: 0 - name: Set up Ruby uses: ruby/setup-ruby@v1 with: @@ -91,16 +84,13 @@ jobs: # @todo Temporary, expect to revert in 0.60 continue-on-error: true - name: Ensure specs still run - run: bundle exec rake spec + # full_spec, not spec: skip the embedded undercover check + run: bundle exec rake full_spec rspec: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - with: - # fetch all history for all branches and tags so we can - # compare against origin/master - fetch-depth: 0 - name: Set up Ruby uses: ruby/setup-ruby@v1 with: @@ -128,7 +118,8 @@ jobs: # @todo Temporary, expect to revert in 0.60 continue-on-error: true - name: Ensure specs still run - run: bundle exec rake spec + # full_spec, not spec: skip the embedded undercover check + run: bundle exec rake full_spec run_solargraph_rspec_specs: # check out solargraph-rspec as well as this project, and point the former to use the latter as a local gem From 4468a4895b5e69b439167d1c19bab4f9166b7fb0 Mon Sep 17 00:00:00 2001 From: Vince Broz Date: Wed, 9 Sep 2026 11:56:50 -0400 Subject: [PATCH 3/3] Drop changelog comments from Plugin job steps The comment on each of the three "Ensure specs still run" steps named what the line used to be rather than what it now does, which reads as a changelog entry. The rake task name already states which suite runs. Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01QRZY46qnEA7iZ9WZJiFae4 --- .github/workflows/plugins.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/plugins.yml b/.github/workflows/plugins.yml index 02abd50bd..cfdd54499 100644 --- a/.github/workflows/plugins.yml +++ b/.github/workflows/plugins.yml @@ -48,7 +48,6 @@ jobs: # @todo Temporary, expect to revert in 0.60 continue-on-error: true - name: Ensure specs still run - # full_spec, not spec: skip the embedded undercover check run: bundle exec rake full_spec rails: runs-on: ubuntu-latest @@ -84,7 +83,6 @@ jobs: # @todo Temporary, expect to revert in 0.60 continue-on-error: true - name: Ensure specs still run - # full_spec, not spec: skip the embedded undercover check run: bundle exec rake full_spec rspec: runs-on: ubuntu-latest @@ -118,7 +116,6 @@ jobs: # @todo Temporary, expect to revert in 0.60 continue-on-error: true - name: Ensure specs still run - # full_spec, not spec: skip the embedded undercover check run: bundle exec rake full_spec run_solargraph_rspec_specs: