Cleanup more code

Author: Reamer

zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java

@@ -1685,7 +1685,7 @@ public void onOutputUpdated(String noteId, String paragraphId, int index,
     try {
       Note note = getNotebook().getNote(noteId);
       if (note == null) {
-        LOG.warn("Note " + noteId + " note found");
+        LOG.warn("Note {} note found", noteId);
         return;
       }
       Paragraph paragraph = note.getParagraph(paragraphId);

zeppelin-server/src/test/java/org/apache/zeppelin/rest/NotebookRestApiTest.java

@@ -42,7 +42,6 @@
 import java.io.IOException;
 import java.nio.charset.StandardCharsets;
 import java.util.HashMap;
-import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Set;
@@ -136,7 +135,7 @@ public void testRunParagraphJob() throws Exception {
       assertEquals("OK", resp.get("status"));
       post.close();
       p.waitUntilFinished();
-      assertNotEquals(p.getStatus(), Job.Status.FINISHED);
+      assertNotEquals(Job.Status.FINISHED, p.getStatus());
     } finally {
       // cleanup
       if (null != note1) {
@@ -167,7 +166,7 @@ public void testRunParagraphSynchronously() throws IOException {
           new TypeToken<Map<String, Object>>() {}.getType());
       assertEquals("OK", resp.get("status"));
       post.close();
-      assertNotEquals(p.getStatus(), Job.Status.READY);
+      assertNotEquals(Job.Status.READY, p.getStatus());
 
       // Check if the paragraph is emptied
       assertEquals(title, p.getTitle());
@@ -189,7 +188,7 @@ public void testRunParagraphSynchronously() throws IOException {
       assertTrue(interpreterResults.get(0).toString(),
               interpreterResults.get(0).get("data").toString().contains("invalid_cmd: command not found"));
       post.close();
-      assertNotEquals(p.getStatus(), Job.Status.READY);
+      assertNotEquals(Job.Status.READY, p.getStatus());
 
       // Check if the paragraph is emptied
       assertEquals(title, p.getTitle());

zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Note.java

@@ -188,7 +188,7 @@ public String getPath() {
   }
 
   public String getParentPath() {
-    int pos = path.lastIndexOf("/");
+    int pos = path.lastIndexOf('/');
     if (pos == 0) {
       return "/";
     } else {
@@ -197,7 +197,7 @@ public String getParentPath() {
   }
 
   private String getName(String path) {
-    int pos = path.lastIndexOf("/");
+    int pos = path.lastIndexOf('/');
     return path.substring(pos + 1);
   }
 
@@ -329,7 +329,7 @@ public void setName(String name) {
         this.path = "/" + name;
       }
     } else {
-      int pos = this.path.lastIndexOf("/");
+      int pos = this.path.lastIndexOf('/');
       this.path = this.path.substring(0, pos + 1) + this.name;
     }
   }

zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java

@@ -367,12 +367,12 @@ public Folder getTrashFolder() {
   }
 
   private String getFolderName(String notePath) {
-    int pos = notePath.lastIndexOf("/");
+    int pos = notePath.lastIndexOf('/');
     return notePath.substring(0, pos);
   }
 
   private String getNoteName(String notePath) {
-    int pos = notePath.lastIndexOf("/");
+    int pos = notePath.lastIndexOf('/');
     return notePath.substring(pos + 1);
   }