From 158203cdc859bd157e52ddb8e89578825b4ee085 Mon Sep 17 00:00:00 2001
From: ocket8888 <ocket8888@gmail.com>
Date: Mon, 16 Dec 2019 12:32:58 -0700
Subject: [PATCH] Fixed segfault in DS Request validation

---
 lib/go-tc/deliveryservice_requests.go | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/lib/go-tc/deliveryservice_requests.go b/lib/go-tc/deliveryservice_requests.go
index a8b163d41e..873c8902e8 100644
--- a/lib/go-tc/deliveryservice_requests.go
+++ b/lib/go-tc/deliveryservice_requests.go
@@ -275,7 +275,7 @@ func (d *DeliveryServiceRequestRequest) Validate() error {
 		validation.Field(&details.Customer, validation.Required),
 		validation.Field(&details.DeepCachingType, validation.By(
 			func(t interface{}) error {
-				if t == nil {
+				if t == (*DeepCachingType)(nil) {
 					return errors.New("deepCachingType: required")
 				}
 				if *t.(*DeepCachingType) == DeepCachingTypeInvalid {
@@ -285,7 +285,7 @@ func (d *DeliveryServiceRequestRequest) Validate() error {
 			})),
 		validation.Field(&details.DeliveryProtocol, validation.By(
 			func(p interface{}) error {
-				if p == nil {
+				if p == (*Protocol)(nil) {
 					return errors.New("deliveryProtocol: required")
 				}
 				if *p.(*Protocol) == ProtocolInvalid {
@@ -295,28 +295,28 @@ func (d *DeliveryServiceRequestRequest) Validate() error {
 			})),
 		validation.Field(&details.HasNegativeCachingCustomization, validation.By(
 			func(h interface{}) error {
-				if h == nil {
+				if h == (*bool)(nil) {
 					return errors.New("hasNegativeCachingCustomization: required")
 				}
 				return nil
 			})),
 		validation.Field(&details.HasOriginACLWhitelist, validation.By(
 			func(h interface{}) error {
-				if h == nil {
+				if h == (*bool)(nil) {
 					return errors.New("hasNegativeCachingCustomization: required")
 				}
 				return nil
 			})),
 		validation.Field(&details.HasOriginDynamicRemap, validation.By(
 			func(h interface{}) error {
-				if h == nil {
+				if h == (*bool)(nil) {
 					return errors.New("hasNegativeCachingCustomization: required")
 				}
 				return nil
 			})),
 		validation.Field(&details.HasSignedURLs, validation.By(
 			func(h interface{}) error {
-				if h == nil {
+				if h == (*bool)(nil) {
 					return errors.New("hasNegativeCachingCustomization: required")
 				}
 				return nil
@@ -324,7 +324,7 @@ func (d *DeliveryServiceRequestRequest) Validate() error {
 		validation.Field(&details.MaxLibrarySizeEstimate, validation.Required),
 		validation.Field(&details.OriginHeaders, validation.By(
 			func(h interface{}) error {
-				if h == nil {
+				if h == (*OriginHeaders)(nil) {
 					return nil
 				}
 				if len(*h.(*OriginHeaders)) < 1 {
@@ -341,7 +341,7 @@ func (d *DeliveryServiceRequestRequest) Validate() error {
 		validation.Field(&details.RoutingName, validation.Required),
 		validation.Field(&details.RoutingType, validation.By(
 			func(t interface{}) error {
-				if t == nil || *(t.(*DSType)) == "" {
+				if t == (*DSType)(nil) || *(t.(*DSType)) == "" {
 					return errors.New("routingType: required")
 				}
 				*t.(*DSType) = DSTypeFromString(string(*t.(*DSType)))