Skip to content

[PARQUET-1719] Make ParquetReader(List<InputFile>, ParquetReadOptions, ReadSupport<T>) constructor public#707

Closed
dssysolyatin wants to merge 2 commits intoapache:masterfrom
dssysolyatin:parquet-1719
Closed

[PARQUET-1719] Make ParquetReader(List<InputFile>, ParquetReadOptions, ReadSupport<T>) constructor public#707
dssysolyatin wants to merge 2 commits intoapache:masterfrom
dssysolyatin:parquet-1719

Conversation

@dssysolyatin
Copy link
Copy Markdown

@dssysolyatin dssysolyatin commented Dec 12, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following PARQUET-1719 issues "PARQUET-1719: Make ParquetReader(List, ParquetReadOptions, ReadSupport) constructor public"

Tests

  • My PR does not need testing for this extremely good reason: No new functions were added

Commits

  • My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

Comment thread parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetReader.java Outdated
@dssysolyatin
Copy link
Copy Markdown
Author

I’m closing this PR since it’s been about 6 years since the issue was created and 3 years since the last discussion. It seems like nobody needed this except me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants