HDDS-12624. Fixing testcase and adressed review comments

Author: priyeshkaratha

hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineProvider.java

@@ -148,7 +148,7 @@ public synchronized Pipeline create(RatisReplicationConfig replicationConfig,
       throws IOException {
     if (exceedPipelineNumberLimit(replicationConfig)) {
       String limitInfo = (maxPipelinePerDatanode > 0)
-          ? String.format("per dataNode: %d", maxPipelinePerDatanode)
+          ? String.format("per datanode: %d", maxPipelinePerDatanode)
           : String.format(": %d", pipelineNumberLimit);
 
       throw new SCMException(

hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestRatisPipelineProvider.java

@@ -384,7 +384,7 @@ public void testCreatePipelineThrowErrorWithDataNodeLimit(int limit, int pipelin
 
     // Validate exception message.
     String expectedError = String.format(
-        "Ratis pipeline number meets the limit per dataNode: %d replicationConfig: RATIS/THREE", limit);
+        "Ratis pipeline number meets the limit per datanode: %d replicationConfig: RATIS/THREE", limit);
     assertEquals(expectedError, exception.getMessage());
   }
 

hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestRatisPipelineCreateAndDestroy.java

@@ -145,7 +145,7 @@ public void testPipelineCreationOnNodeRestart() throws Exception {
         pipelineManager.createPipeline(RatisReplicationConfig.getInstance(
             ReplicationFactor.THREE)),
         "pipeline creation should fail after shutting down pipeline");
-    assertEquals(SCMException.ResultCodes.FAILED_TO_FIND_HEALTHY_NODES, ioe.getResult());
+    assertEquals(SCMException.ResultCodes.FAILED_TO_FIND_SUITABLE_NODE, ioe.getResult());
 
     // make sure pipelines is destroyed
     waitForPipelines(0);