Skip to content

Commit 0701d6a

Browse files
authored
HDDS-13248. Remove ozone debug replicas verify option --output-dir (#8612)
1 parent ca1afe8 commit 0701d6a

4 files changed

Lines changed: 3 additions & 8 deletions

File tree

hadoop-ozone/dist/src/main/smoketest/debug/ozone-debug-tests.robot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Write keys
3737

3838
*** Test Cases ***
3939
Test ozone debug replicas verify checksums
40-
${output} = Execute ozone debug replicas verify --checksums --block-existence --container-state o3://${OM_SERVICE_ID}/${VOLUME}/${BUCKET}/${TESTFILE} --output-dir ${TEMP_DIR}
40+
${output} = Execute ozone debug replicas verify --checksums --block-existence --container-state o3://${OM_SERVICE_ID}/${VOLUME}/${BUCKET}/${TESTFILE}
4141
${json} = Evaluate json.loads('''${output}''') json
4242

4343
# 'keys' array should be empty if all keys and their replicas passed checksum verification

hadoop-ozone/dist/src/main/smoketest/debug/ozone-debug.robot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ ${OM_SERVICE_ID} %{OM_SERVICE_ID}
2323

2424
*** Keywords ***
2525
Execute replicas verify checksums CLI tool
26-
Execute ozone debug -Dozone.network.topology.aware.read=true replicas verify --checksums --output-dir ${TEMP_DIR} o3://${OM_SERVICE_ID}/${VOLUME}/${BUCKET}/${TESTFILE}
26+
Execute ozone debug -Dozone.network.topology.aware.read=true replicas verify --checksums o3://${OM_SERVICE_ID}/${VOLUME}/${BUCKET}/${TESTFILE}
2727
${directory} = Execute ls -d ${TEMP_DIR}/${VOLUME}_${BUCKET}_${TESTFILE}_*/ | tail -n 1
2828
Directory Should Exist ${directory}
2929
File Should Exist ${directory}/${TESTFILE}_manifest

hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneDebugShell.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ public void testReplicasVerifyCmd(boolean isEcKey) throws Exception {
104104
getSetConfStringFromConf(OMConfigKeys.OZONE_OM_ADDRESS_KEY),
105105
getSetConfStringFromConf(ScmConfigKeys.OZONE_SCM_CLIENT_ADDRESS_KEY),
106106
"replicas", "verify", "--checksums", "--block-existence", "--container-state", fullKeyPath,
107-
"--output-dir", "/"//, "--all-results"
107+
//, "--all-results"
108108
};
109109

110110
int exitCode = ozoneDebugShell.execute(args);

hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/replicas/ReplicasVerify.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,6 @@ public class ReplicasVerify extends Handler {
5555
description = Shell.OZONE_URI_DESCRIPTION)
5656
private String uri;
5757

58-
@CommandLine.Option(names = {"-o", "--output-dir"},
59-
description = "Destination directory to save the generated output.",
60-
required = true)
61-
private String outputDir;
62-
6358
@CommandLine.Option(names = {"--all-results"},
6459
description = "Print results for all passing and failing keys")
6560
private boolean allResults;

0 commit comments

Comments
 (0)