TreeUtilities: fix record span computation#8937
Merged
Merged
Conversation
mbien
added
Java
Member
Author
|
oops. looks like a few tests failed. |
mbien
force-pushed
the
fix-record-spans
branch
from
3d022e3 to
04f07e9
Compare
Member
Author
|
@jlahoda can you take a look at this PR too? |
lahodaj
approved these changes
Nov 2, 2025
Contributor
lahodaj
left a comment
lahodaj
left a comment
There was a problem hiding this comment.
Looks good to me, thanks. One typo inline.
ErrorDescriptionFactory can now compute spans for record declarations. This allows hints like Unused to correctly annotate spans on records. TreeUtilities: use compact Collections and minor cleanup.
mbien
force-pushed
the
fix-record-spans
branch
from
04f07e9 to
8d3145a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ErrorDescriptionFactorycan now compute spans for record declarations. This allows hints like Unused to correctly highlight hints on records.TreeUtilities: use compact Collections and minor cleanup.note:
recordis parsed as an identifier token since it is no reserved keyword, that is why this needs special casing.before:
after:
