Skip to content

[TIR][Logger]Buffer logger assert removed#6147

Merged
tqchen merged 1 commit into
apache:masterfrom
ANSHUMAN87:tir-printer-bug
Jul 30, 2020
Merged

[TIR][Logger]Buffer logger assert removed#6147
tqchen merged 1 commit into
apache:masterfrom
ANSHUMAN87:tir-printer-bug

Conversation

@ANSHUMAN87

Copy link
Copy Markdown
Contributor

This PR addressed below issue:
When i try to log stmt input in InjectPrefetch Pass using AsText(stmt), i get below error

TVMError: Check failed: memo_buf_.count(buffer) > 0 (0 vs. 0) : 
Error during compile function

cc @tqchen , @spectrometerHBH , @junrushao1994

@spectrometerHBH

Copy link
Copy Markdown
Contributor

I've noticed this problem at the same time. My advice is to print the buffer information in the header, and use there unique name to reference them in the body of IR.

@ANSHUMAN87

Copy link
Copy Markdown
Contributor Author

I've noticed this problem at the same time. My advice is to print the buffer information in the header, and use there unique name to reference them in the body of IR.

Thanks @spectrometerHBH !
I believe i have also done the same thing. Please let me know if i am mistaken.

Comment thread src/printer/tir_text_printer.cc
@ANSHUMAN87

Copy link
Copy Markdown
Contributor Author

@tqchen , @spectrometerHBH : In case there is no further comment. May be we can merge this one. TIA!

@spectrometerHBH

Copy link
Copy Markdown
Contributor

LGTM

@tqchen tqchen merged commit 68e21fe into apache:master Jul 30, 2020
@tqchen

tqchen commented Jul 30, 2020

Copy link
Copy Markdown
Member

Thanks @ANSHUMAN87 @spectrometerHBH

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Sep 2, 2020
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 3, 2020
@spectrometerHBH spectrometerHBH mentioned this pull request Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants