Skip to content

Commit 827cab9

Browse files
author
Brent Gardner
authored
Fix code generation for json feature (#3367)
1 parent ede82fb commit 827cab9

3 files changed

Lines changed: 12 additions & 2 deletions

File tree

datafusion/proto/build.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ fn build() -> Result<(), String> {
5555
let mut file = std::fs::OpenOptions::new()
5656
.write(true)
5757
.create(true)
58-
.open("src/generated/datafusion.rs")
58+
.open("src/generated/datafusion_json.rs")
5959
.unwrap();
6060
file.write(proto.as_str().as_ref()).unwrap();
6161
file.write(json.as_str().as_ref()).unwrap();

datafusion/proto/src/generated/mod.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,10 @@
1818
// include the generated protobuf source as a submodule
1919
#[allow(clippy::all)]
2020
#[rustfmt::skip]
21+
#[cfg(not(feature = "json"))]
2122
pub mod datafusion;
23+
24+
#[allow(clippy::all)]
25+
#[rustfmt::skip]
26+
#[cfg(feature = "json")]
27+
pub mod datafusion_json;

datafusion/proto/src/lib.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,11 @@ pub mod from_proto;
2424
pub mod generated;
2525
pub mod logical_plan;
2626
pub mod to_proto;
27-
use generated::datafusion as protobuf;
27+
28+
#[cfg(not(feature = "json"))]
29+
pub use generated::datafusion as protobuf;
30+
#[cfg(feature = "json")]
31+
pub use generated::datafusion_json as protobuf;
2832

2933
#[cfg(doctest)]
3034
doc_comment::doctest!("../README.md", readme_example_test);

0 commit comments

Comments
 (0)