Skip to content

Fixes #81 - Add CI workflow for source distribution #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 1 commit into from
Dec 1, 2022
Merged

Fixes #81 - Add CI workflow for source distribution #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed .DS_Store
View file
Open in desktop
Binary file not shown.
26 changes: 26 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,32 @@ jobs:
name: dist
path: target/wheels/*

build-sdist:
needs: [generate-license]
name: Source distribution
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- run: rm LICENSE.txt
- name: Download LICENSE.txt
uses: actions/download-artifact@v2
with:
name: python-wheel-license
path: .
- run: cat LICENSE.txt
- name: Build sdist
run: |
docker run --rm -v $(pwd):/io \
--workdir /io \
ghcr.io/pyo3/maturin:v0.14.2 \
build --release --sdist --locked
find target/wheels/
- name: Archive wheels
uses: actions/upload-artifact@v2
with:
name: dist
path: target/wheels/*

# NOTE: PyPI publish needs to be done manually for now after release passed the vote
# release:
# name: Publish in PyPI
Expand Down
7 changes: 6 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,9 @@ repository = "https://github.com/apache/arrow-datafusion-python"
profile = "black"

[tool.maturin]
sdist-include = ["Cargo.lock"]
include = [
{ path = "Cargo.lock", format = "sdist" }
]
exclude = [".github/**", "ci/**", ".asf.yaml"]
# Require Cargo.lock is up to date
locked = true
Copy link
Copy Markdown
Member

@andygrove andygrove Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this fail the build if Cargo.lock is not up-to-date? This action doesn't run until we tag the release candidate so there is a good chance this will fail unless we also have a CI check on PRs to make sure Cargo.lock is up-to-date?

Copy link
Copy Markdown
Member Author

@martin-g martin-g Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the build workflow is not enabled for Pull Requests ?
It does not publish anything. I think it is safe to enable it! This way we could notice problems earlier!

Copy link
Copy Markdown
Member

@andygrove andygrove Dec 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 makes sense to me