build(deps): upgrade actions/{upload,download}-artifact@v3 to v4#829
Merged
andygrove merged 5 commits intoAug 23, 2024
Merged
Conversation
Uploads are now immutable for actions/upload-artifact@v4. This gives each build artifact a unique key, and then merges them together at the end. The [migration guide] suggests this pattern. [migration guide]: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md#merging-multiple-artifacts
Michael-J-Ward
changed the title
This was referenced Aug 22, 2024
timsaucer
approved these changes
Aug 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The text of the PR has undergone significant changes since this morning on 2024-08-22. I noticed and tracked down some bugs in the build behavior that existed prior to this PR but went unnoticed. The result of that investigation is the two follow-on issues at the end.
Which issue does this PR close?
Closes #724.
Rationale for this change
v3 will be disabled 2024-11-30.
The change between
actions/upload-artifact@v3andv4that impacted us was that each artifact is now immutable.With v3, a wheel would be built for each target platform and then uploaded to the same
distartifact, which would aggregate the artifacts in an archive.With v4, all but the 1st attempt to upload to
distfails with this errorWhat changes are included in this PR?
To achieve this same behavior with v4, each build target must upload to its own unique key before merging them as a final step, as suggested in the migration guide.
Although the build workflow now produces a
dist-*artifact for each build target, the final mergeddist.zipartifact has the same structure as before.Warning
Notice
build.ymlworkflow should create 6 artifacts, but bothdist.zip's only contain 4 artifacts. See Additional Context at end.Build Summary from 40.1.0 release
Build Summary from this PR
Are there any user-facing changes?
There shouldn't be.
Additional Context
This PR upgrades the action while maintaining current behavior. I assume we'll want a follow-on PR to address the two following warnings.
macos-latestis ARM64 #831build-sdistjob #832