Update conda build/host deps to avoid overlinking issues#438
Closed
charlesbluca wants to merge 2 commits into
Closed
Update conda build/host deps to avoid overlinking issues#438charlesbluca wants to merge 2 commits into
charlesbluca wants to merge 2 commits into
Conversation
Contributor
Author
|
Closing this out in favor of #350 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
n/a
Rationale for this change
Our conda nightly builds emit some warnings around overlinking:
That seem to be due to leaving out some build/host requirements that should be explicitly specified. This PR does this using the same approach taken in conda-forge/staged-recipes#23386 to resolve overlinking issues in a similar maturin project.
What changes are included in this PR?
Adds Rust / C compilers to build deps to resolve the
libgcc_s.so.1dependency, andxzto the host deps to resolve theliblzma.so.5dependencyAre there any user-facing changes?
n/a