feature: Improve string representation of datafusion classes#159
Conversation
| expr.into() | ||
| } | ||
|
|
||
| fn __str__(&self) -> PyResult<String> { |
There was a problem hiding this comment.
Removed since redundant if implemented the same way, e.g. str(literal(5)) will fall back to __repr__ if __str__ is not implemented)
jdye64
left a comment
jdye64
left a comment
There was a problem hiding this comment.
@simicd LGTM. Thanks for this. As Andy mentioned we are aware of the CI issue. I just pushed some changes to PR after having Apache infra whitelist a github action for protoc which is what was causing the issue. It might take a few iterations from me there to get it all working but hopefully within a day it should all be sorted out
|
@andygrove and @simicd sorry for the delay but the CI fix PR is ready for review now if either of you want to take a look #162 @simicd after this merges if you want to merge into this PR your CI build should work as well and we can get your PR merged in. |
simicd
force-pushed
the
feature/improve-repl-output
branch
from
ca47e29 to
0ede908
Compare
|
Thanks a lot @jdye64! Checks passed now |
|
@simicd nice! Yep, I don't have commit permissions but looks good now |
3 participants
Which issue does this PR close?
Closes #158.
Rationale for this change
Improve developer experience
What changes are included in this PR?
Implement
__repr__methods of the following classes:Are there any user-facing changes?
Display additional information when debugging or using REPL tools