Skip to content

update GH Build workflow now that macos-latest is ARM64 #831

@Michael-J-Ward

Description

@Michael-J-Ward

Follow on from #829

Change Required

build.yml needs to be updated macos builds now that macos-latest is ARM64. Also

To prevent the sand from shifting under our feet in the future, we should switch to explicit macos versions for the different builds.

  • macos-14 for building arm64
  • macos-13 for building x86_64

Explanation

I yanked this from the PR. It contains way more detail than necessary because I didn't realize that the macos-runner changed.


dist-macos-aarch64.zip and dist-macos-latest.zip contain different files with the same name

Looking at the workflow file, build-macos-aarch does set --target aarch64-apple-darwin and that does result in a different file, but maturin seemingly ignores the target flag when it names the file.

In both the prior workflow and in this PR, the end result is that dist.zip would contain only one of the two wheels.

Same file name

unzip -l dist-macos-aarch64.zip 
Archive:  dist-macos-aarch64.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
 15158055  08-22-2024 04:11   datafusion-40.0.0-cp38-abi3-macosx_11_0_arm64.whl
---------                     -------
 15158055                     1 fileunzip -l dist-macos-latest.zip 
Archive:  dist-macos-latest.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
 15154519  08-22-2024 04:10   datafusion-40.0.0-cp38-abi3-macosx_11_0_arm64.whl
---------                     -------
 15154519                     1 file

Different file contents

unzip -p dist-macos-aarch64.zip | sha256sum 
f717caa8c810130d50663d4673b2a3051fe4e3eacdd3922e16ae1344f2939663  -unzip -p dist-macos-latest.zip | sha256sum 
e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  -

Looking at the docs, it looks like the names for the two macos wheels used to be different.

Click on the action and scroll down to the bottom of the page titled "Artifacts". Download `dist.zip`. It should
contain files such as:
```text
datafusion-22.0.0-cp37-abi3-macosx_10_7_x86_64.whl
datafusion-22.0.0-cp37-abi3-macosx_11_0_arm64.whl
datafusion-22.0.0-cp37-abi3-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
datafusion-22.0.0-cp37-abi3-win_amd64.whl
```

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions