Skip to content

Commit fa0041b

Browse files
committed
backwards compatibility + fixed = TRUE
1 parent 306751f commit fa0041b

3 files changed

Lines changed: 11 additions & 1 deletion

File tree

r/extra-tests/test-read-files.R

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,8 @@ test_that("Can see the extra metadata (parquet)", {
168168
if (if_version_less_than("3.0.0")) {
169169
expect_warning(
170170
df <- read_parquet(pq_file),
171-
"Invalid metadata$r"
171+
"Invalid metadata$r",
172+
fixed = TRUE
172173
)
173174
expect_s3_class(df, "tbl")
174175
} else {
Binary file not shown.

r/tests/testthat/test-backwards-compatibility.R

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,15 @@ expect_identical_with_metadata <- function(object, expected, ..., top_level = TR
4545
expect_identical(object, expected, ...)
4646
}
4747

48+
test_that("reading a known Parquet file to dataframe with 3.0.0", {
49+
skip_if_not_available("snappy")
50+
pq_file <- test_path("golden-files/data-arrow-extra-meta_3.0.0.parquet")
51+
52+
df <- read_parquet(pq_file)
53+
# this is equivalent to `expect_identical()`
54+
expect_identical_with_metadata(df, example_with_extra_metadata)
55+
})
56+
4857
test_that("reading a known Parquet file to dataframe with 2.0.0", {
4958
skip_if_not_available("snappy")
5059
pq_file <- test_path("golden-files/data-arrow_2.0.0.parquet")

0 commit comments

Comments
 (0)