Skip to content

Commit 6b52026

Browse files
committed
Expand test coverage
1 parent f3a7307 commit 6b52026

1 file changed

Lines changed: 12 additions & 5 deletions

File tree

rust/arrow/src/compute/kernels/arithmetic.rs

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -839,11 +839,8 @@ mod tests {
839839
let a = Int32Array::from(vec![15, 14, 9, 8, 1]);
840840
let b = 3;
841841
let c = divide_scalar(&a, b).unwrap();
842-
assert_eq!(5, c.value(0));
843-
assert_eq!(4, c.value(1));
844-
assert_eq!(3, c.value(2));
845-
assert_eq!(2, c.value(3));
846-
assert_eq!(0, c.value(4));
842+
let expected = Int32Array::from(vec![5, 4, 3, 2, 0]);
843+
assert_eq!(c, expected);
847844
}
848845

849846
#[test]
@@ -877,6 +874,16 @@ mod tests {
877874
assert_eq!(true, c.is_null(5));
878875
}
879876

877+
#[test]
878+
fn test_primitive_array_divide_scalar_with_nulls() {
879+
let a = Int32Array::from(vec![Some(15), None, Some(8), Some(1), Some(9), None]);
880+
let b = 3;
881+
let c = divide_scalar(&a, b).unwrap();
882+
let expected =
883+
Int32Array::from(vec![Some(5), None, Some(2), Some(0), Some(3), None]);
884+
assert_eq!(c, expected);
885+
}
886+
880887
#[test]
881888
fn test_primitive_array_divide_with_nulls_sliced() {
882889
let a = Int32Array::from(vec![

0 commit comments

Comments
 (0)