From d984fdea2781bb2c996a96fb8a0922208d655735 Mon Sep 17 00:00:00 2001 From: utkarsh sharma Date: Wed, 17 May 2023 15:32:53 +0530 Subject: [PATCH 1/2] Add test_connection method to PagerdutyHook --- airflow/providers/pagerduty/hooks/pagerduty.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/airflow/providers/pagerduty/hooks/pagerduty.py b/airflow/providers/pagerduty/hooks/pagerduty.py index 7e138ecebbad5..eb24c3ec31272 100644 --- a/airflow/providers/pagerduty/hooks/pagerduty.py +++ b/airflow/providers/pagerduty/hooks/pagerduty.py @@ -159,3 +159,11 @@ def create_event( images=images, links=links, ) + + def test_connection(self): + try: + session = pdpyras.APISession(self.token) + session.list_all("services", params={"query": "some_non_existing_service"}) + except Exception as e: + return False, str(e) + return True, "connection tested successfully" From 90950e49c03a295075ffb868b86109c7302c3c3e Mon Sep 17 00:00:00 2001 From: utkarsh sharma Date: Wed, 17 May 2023 15:56:46 +0530 Subject: [PATCH 2/2] update the error message --- airflow/providers/pagerduty/hooks/pagerduty.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/airflow/providers/pagerduty/hooks/pagerduty.py b/airflow/providers/pagerduty/hooks/pagerduty.py index eb24c3ec31272..e1b4de123057e 100644 --- a/airflow/providers/pagerduty/hooks/pagerduty.py +++ b/airflow/providers/pagerduty/hooks/pagerduty.py @@ -164,6 +164,6 @@ def test_connection(self): try: session = pdpyras.APISession(self.token) session.list_all("services", params={"query": "some_non_existing_service"}) - except Exception as e: - return False, str(e) + except Exception: + return False, "connection test failed, invalid token" return True, "connection tested successfully"