diff --git a/chart/newsfragments/28822.significant b/chart/newsfragments/28822.significant new file mode 100644 index 0000000000000..6ca95d1b21770 --- /dev/null +++ b/chart/newsfragments/28822.significant @@ -0,0 +1 @@ +The Chart does not allow to use both dags.persistence and dags.gitSync enabled together. This was a problematic combinations anyway and did not work as intended. The Chart now prevents this combination from being used. diff --git a/chart/templates/check-values.yaml b/chart/templates/check-values.yaml index 81fb80901730c..025fdcba2b2fc 100644 --- a/chart/templates/check-values.yaml +++ b/chart/templates/check-values.yaml @@ -60,3 +60,7 @@ The sole purpose of this yaml file is it to check the values file is consistent {{- end }} {{- end }} + + {{- if and .Values.dags.persistence.enabled .Values.dags.gitSync.enabled }} + {{ required "The combination of dags persistence and gitSync has serious performance and atomicity issues. Choose either gitSync or dags persistence but not the two of them together." nil }} + {{- end }} diff --git a/chart/values.yaml b/chart/values.yaml index 17231711ee342..37f051a14607b 100644 --- a/chart/values.yaml +++ b/chart/values.yaml @@ -1813,6 +1813,7 @@ dags: ## optional subpath for dag volume mount subPath: ~ gitSync: + # Enable git sync sidecar for dags. Cannot be set to True together with dags.persistence.enabled = True enabled: false # git repo clone url