feat(i18n): add Farsi (fa) locale for app, UI, and desktop - #40386
Closed
pourmirzai wants to merge 1 commit into
Closed
feat(i18n): add Farsi (fa) locale for app, UI, and desktop#40386pourmirzai wants to merge 1 commit into
pourmirzai wants to merge 1 commit into
Conversation
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found The search results show PR #40386 (the current PR) and related but distinct PRs that are intentionally scoped separately:
|
Author
|
Will resubmit on updated dev base |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Builds on localization work in #37184 (docs/README/glossary fa) and #34396 (closed), fills the app/UI/desktop locale gap left by auto-closed #33338.
Type of change
What does this PR does
Adds full Persian (Farsi, fa) locale support for non-terminal surfaces — app web UI, shared UI components, and desktop Electron wrapper — with complete key/placeholder parity.
Files changed:
otes/fa-audit.md (existing RTL PRs audit, gap analysis)
Key parity verified: 996/996 (app), 171/171 (ui), 21/21 (desktop), 0 placeholder mismatches.
Deliberate scope decisions:
How did you verify your code works
Ran official parity.test.ts with bun — all fa parity checks pass:
Note: parity.test.ts fails on �r locale (5 missing keys: dialog.provider.custom.label, dialog.model.unpaid.viewMoreProviders, session.header.reveal.finder/fileExplorer/containingFolder). This is a pre-existing gap in dev, unrelated to fa.
Screenshots / recordings
N/A (i18n strings only — no UI layout changes; RTL will follow via #39423).
Checklist