From e64023ada60d94984fd49cd4e3491c280e379a52 Mon Sep 17 00:00:00 2001 From: Petr Plenkov Date: Mon, 20 Apr 2026 10:10:59 +0200 Subject: [PATCH] docs(petstore3-client): remove reference to internal SAP system ID The e2e README named an internal SAP system ID as a secondary deploy target. Strip those references and keep only the public-facing evidence; the BTP packaging advice is generalised and no longer tied to a specific tenant. --- samples/petstore3-client/e2e/README.md | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/samples/petstore3-client/e2e/README.md b/samples/petstore3-client/e2e/README.md index 24dea2135..6549d7bd8 100644 --- a/samples/petstore3-client/e2e/README.md +++ b/samples/petstore3-client/e2e/README.md @@ -2,11 +2,11 @@ This directory contains the **hand-written AUnit test class** (`src/zcl_ps3_client_tests.clas.abap`) deployed alongside the generated `ZCL_PETSTORE3_CLIENT` to prove that the code generated by `@abapify/openai-codegen` is **usable on a live SAP BTP Steampunk (cloud ABAP) system**. -## Evidence gathered on live SAP BTP systems +## Evidence gathered on live SAP BTP Steampunk -The generator was exercised against two Steampunk tenants. Both flows produce the same body; the only thing that varied was the target package. +The generator was exercised against a real Steampunk tenant (`TRL`). -### Successful deploy on `TRL` (BTP Steampunk, package `ZPEPL`) +### Successful deploy on `TRL` (package `ZPEPL`) | Step | Command | Result | | --------------------------------- | ------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------------------------------------- | @@ -15,13 +15,9 @@ The generator was exercised against two Steampunk tenants. Both flows produce th | Verify generated source on server | `bunx adt --sid TRL fetch /sap/bc/adt/oo/classes/zcl_petstore3_client/source/main` | OK — returns the generator's output byte-for-byte | | Verify class metadata | `bunx adt --sid TRL fetch /sap/bc/adt/oo/classes/zcl_petstore3_client` | OK — `adtcore:masterSystem="TRL"`, `class:category="generalObjectType"` | -### Successful deploy on `BHF` (BTP Steampunk, package `$TMP`) +## Important: `--package` must be a user-writable package on BTP -Same generated artefacts, deployed to `$TMP` on `BHF` where the service account has `S_ABPLNGVS` for that package — same `2 objects activated` result. - -## Important: `--package` must be a user-writable package on TRL - -On TRL, the current service account does NOT have `S_ABPLNGVS` authorization for `$TMP`. Deploying there with `--package $TMP` fails with: +On BTP Steampunk, `S_ABPLNGVS` authorization is granted per package. Deploying with `--package $TMP` can fail with: ``` HTTP 403: Forbidden - You are not authorized to make changes (authorization object S_ABPLNGVS)