Rename VoidWithTypeParameters to VoidWithTypeArguments.

Change-Id: I5df6a49f0b27b6edfe2ce0f677d5f898900d8384
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

Author: scheglov

pkg/_fe_analyzer_shared/lib/src/messages/codes_generated.dart

@@ -8682,14 +8682,14 @@ const MessageCode messageVoidExpression = const MessageCode("VoidExpression",
     message: r"""This expression has type 'void' and can't be used.""");
 
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const Code<Null> codeVoidWithTypeParameters = messageVoidWithTypeParameters;
+const Code<Null> codeVoidWithTypeArguments = messageVoidWithTypeArguments;
 
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
-const MessageCode messageVoidWithTypeParameters = const MessageCode(
-    "VoidWithTypeParameters",
+const MessageCode messageVoidWithTypeArguments = const MessageCode(
+    "VoidWithTypeArguments",
     index: 100,
-    message: r"""Type 'void' can't have type parameters.""",
-    tip: r"""Try removing the type parameters.""");
+    message: r"""Type 'void' can't have type arguments.""",
+    tip: r"""Try removing the type arguments.""");
 
 // DO NOT EDIT. THIS FILE IS GENERATED. SEE TOP OF FILE.
 const Template<

pkg/_fe_analyzer_shared/lib/src/parser/type_info_impl.dart

@@ -364,7 +364,7 @@ class VoidType implements TypeInfo {
       if (typeParam != noTypeParamOrArg) {
         hasTypeArguments = true;
         parser.reportRecoverableError(
-            token.next, codes.messageVoidWithTypeParameters);
+            token.next, codes.messageVoidWithTypeArguments);
         token = typeParam.parseArguments(token, parser);
       }
     }

pkg/analyzer/lib/src/dart/error/syntactic_errors.dart

@@ -882,7 +882,7 @@ class ParserErrorCode extends ErrorCode {
               "replacing it with the name of the return type.");
 
   static const ParserErrorCode VOID_WITH_TYPE_ARGUMENTS =
-      _VOID_WITH_TYPE_PARAMETERS;
+      _VOID_WITH_TYPE_ARGUMENTS;
 
   /**
    * Initialize a newly created error code to have the given [name]. The message

pkg/analyzer/lib/src/dart/error/syntactic_errors.g.dart

@@ -107,7 +107,7 @@ final fastaAnalyzerErrorCodes = <ErrorCode>[
   _MULTIPLE_VARIANCE_MODIFIERS,
   _INVALID_USE_OF_COVARIANT_IN_EXTENSION,
   _TYPE_PARAMETER_ON_CONSTRUCTOR,
-  _VOID_WITH_TYPE_PARAMETERS,
+  _VOID_WITH_TYPE_ARGUMENTS,
 ];
 
 const ParserErrorCode _ABSTRACT_CLASS_MEMBER = ParserErrorCode(
@@ -575,9 +575,9 @@ const ParserErrorCode _VAR_RETURN_TYPE = ParserErrorCode(
     correction:
         "Try removing the keyword 'var', or replacing it with the name of the return type.");
 
-const ParserErrorCode _VOID_WITH_TYPE_PARAMETERS = ParserErrorCode(
-    'VOID_WITH_TYPE_PARAMETERS', r"Type 'void' can't have type parameters.",
-    correction: "Try removing the type parameters.");
+const ParserErrorCode _VOID_WITH_TYPE_ARGUMENTS = ParserErrorCode(
+    'VOID_WITH_TYPE_ARGUMENTS', r"Type 'void' can't have type arguments.",
+    correction: "Try removing the type arguments.");
 
 const ParserErrorCode _WITH_BEFORE_EXTENDS = ParserErrorCode(
     'WITH_BEFORE_EXTENDS',

pkg/front_end/messages.yaml

@@ -971,11 +971,11 @@ InvalidVoid:
     - "void x; main() {}"
     - "foo(void x) {} main() { foo(null); }"
 
-VoidWithTypeParameters:
-  template: "Type 'void' can't have type parameters."
-  tip: "Try removing the type parameters."
+VoidWithTypeArguments:
+  template: "Type 'void' can't have type arguments."
+  tip: "Try removing the type arguments."
   index: 100
-  analyzerCode: ParserErrorCode.VOID_WITH_TYPE_PARAMETERS
+  analyzerCode: ParserErrorCode.VOID_WITH_TYPE_ARGUMENTS
   script:
     - "void<int> f() {}"
 

pkg/front_end/parser_testcases/error_recovery/issue_39958_01.dart.expect

@@ -1,6 +1,6 @@
 Problems reported:
 
-parser/error_recovery/issue_39958_01:1:5: Type 'void' can't have type parameters.
+parser/error_recovery/issue_39958_01:1:5: Type 'void' can't have type arguments.
 void<int> f() {}
     ^
 
@@ -9,7 +9,7 @@ beginCompilationUnit(void)
   endMetadataStar(0)
   beginTopLevelMember(void)
     beginTopLevelMethod(, null)
-      handleRecoverableError(VoidWithTypeParameters, <, <)
+      handleRecoverableError(VoidWithTypeArguments, <, <)
       beginTypeArguments(<)
         handleIdentifier(int, typeReference)
         handleNoTypeArguments(>)

pkg/front_end/parser_testcases/error_recovery/issue_39958_01.dart.intertwined.expect

@@ -10,8 +10,8 @@ parseUnit(void)
       listener: beginTopLevelMember(void)
       parseTopLevelMethod(, null, , Instance of 'VoidType', null, f)
         listener: beginTopLevelMethod(, null)
-        reportRecoverableError(<, VoidWithTypeParameters)
-          listener: handleRecoverableError(VoidWithTypeParameters, <, <)
+        reportRecoverableError(<, VoidWithTypeArguments)
+          listener: handleRecoverableError(VoidWithTypeArguments, <, <)
         listener: beginTypeArguments(<)
         listener: handleIdentifier(int, typeReference)
         listener: handleNoTypeArguments(>)

pkg/front_end/testcases/general/type_parameters_on_void.dart.outline.expect

@@ -2,8 +2,8 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/general/type_parameters_on_void.dart:1:5: Error: Type 'void' can't have type parameters.
-// Try removing the type parameters.
+// pkg/front_end/testcases/general/type_parameters_on_void.dart:1:5: Error: Type 'void' can't have type arguments.
+// Try removing the type arguments.
 // void<int> f() {}
 //     ^
 //

pkg/front_end/testcases/general/type_parameters_on_void.dart.strong.expect

@@ -2,8 +2,8 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/general/type_parameters_on_void.dart:1:5: Error: Type 'void' can't have type parameters.
-// Try removing the type parameters.
+// pkg/front_end/testcases/general/type_parameters_on_void.dart:1:5: Error: Type 'void' can't have type arguments.
+// Try removing the type arguments.
 // void<int> f() {}
 //     ^
 //

pkg/front_end/testcases/general/type_parameters_on_void.dart.strong.transformed.expect

@@ -2,8 +2,8 @@ library;
 //
 // Problems in library:
 //
-// pkg/front_end/testcases/general/type_parameters_on_void.dart:1:5: Error: Type 'void' can't have type parameters.
-// Try removing the type parameters.
+// pkg/front_end/testcases/general/type_parameters_on_void.dart:1:5: Error: Type 'void' can't have type arguments.
+// Try removing the type arguments.
 // void<int> f() {}
 //     ^
 //