Repository navigation
Refactor Admin UI / Breadcrumbs to use DS components and design tokens #77012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
19c4b6f
ad46f5f
e9b2a5b
6d0cc1c
e3db280
ba1353c
1eb4298
89c942d
8c07a2f
4d131ea
6c13381
726730d
8c7970b
383de64
edb8c39
72be8e1
6cd0da7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe we can un-nest the |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,33 @@ | ||
| .list { | ||
| /* @TODO: use Text component from UI when available. */ | ||
| font-family: var(--wpds-typography-font-family-heading); | ||
| font-size: var(--wpds-typography-font-size-lg); | ||
| font-weight: var(--wpds-typography-font-weight-medium); | ||
| line-height: var(--wpds-typography-line-height-lg); | ||
| list-style: none; | ||
| padding: 0; | ||
| margin: 0; | ||
| /* gap prop don't seem to be working properly. */ | ||
| gap: 0; | ||
| min-height: 32px; | ||
| /* @TODO: Replace with a `size` token once that category exists in the theme package. */ | ||
| min-height: calc(var(--wpds-dimension-base) * 8); | ||
| } | ||
|
|
||
| /* | ||
| * Preceding items keep their intrinsic width; only the last (current) item | ||
| * is allowed to shrink so that the truncation styles on `.current` engage. | ||
| */ | ||
| .list > li { | ||
| flex-shrink: 0; | ||
| } | ||
|
|
||
| li:not(:last-child)::after { | ||
| content: "/"; | ||
| margin: 0 var(--wpds-dimension-gap-sm); | ||
| } | ||
| .list > li:last-child { | ||
| flex-shrink: 1; | ||
| min-width: 0; | ||
| } | ||
|
|
||
| /* @TODO: Remove truncation styles once `Text` supports truncation natively. */ | ||
| .current { | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
| } | ||
|
|
||
| h1 { | ||
| font-size: inherit; | ||
| line-height: inherit; | ||
| } | ||
| .separator { | ||
| color: var(--wpds-color-stroke-surface-neutral); | ||
| margin: 0 var(--wpds-dimension-gap-sm); | ||
| user-select: none; | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,7 @@ const ALLOWLIST = { | |
| 'Card', | ||
| 'Collapsible', | ||
| 'CollapsibleCard', | ||
| 'Link', | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should probably get a separate CHANGELOG entry in @wordpress/ui, too? Also, looping @mirka in to make sure we're ready to mark it as allowed, and/or if we're happy to do it as part of this PR
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The only remaining issue with
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this is a minor point that can be addressed in a follow-up. |
||
| 'Stack', | ||
| 'Text', | ||
| 'VisuallyHidden', | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we discussed or landed on consensus around
Linkcomponent from@wordpress/routeusingLinkfrom@wordpress/ui?(Something to address separately)