From ba0c877865cf20e718c2f0cd7d98a9a45631c43b Mon Sep 17 00:00:00 2001 From: Simon Cropp Date: Tue, 9 Jun 2026 10:24:31 +1000 Subject: [PATCH] Mark passthrough string Verify overloads as [StringSyntax("*")] --- src/Directory.Build.props | 2 +- src/Verify.Expecto/Verifier_String.cs | 4 ++++ src/Verify.Fixie/Verifier_String.cs | 4 ++++ src/Verify.MSTest/Verifier_String.cs | 4 ++++ src/Verify.MSTest/VerifyBase_String.cs | 4 ++++ src/Verify.NUnit/Verifier_String.cs | 4 ++++ src/Verify.NUnit/VerifyBase_String.cs | 4 ++++ src/Verify.TUnit/Verifier_String.cs | 4 ++++ src/Verify.XunitV3/Verifier_String.cs | 4 ++++ src/Verify.XunitV3/VerifyBase_String.cs | 4 ++++ src/Verify/Verifier/InnerVerifier_String.cs | 8 ++++---- 11 files changed, 41 insertions(+), 5 deletions(-) diff --git a/src/Directory.Build.props b/src/Directory.Build.props index 5c49a9f03a..66758bc768 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -2,7 +2,7 @@ CA1822;CS1591;CS0649;xUnit1026;xUnit1013;CS1573;VerifyTestsProjectDir;VerifySetParameters;PolyFillTargetsForNuget;xUnit1051;NU1608;NU1109 - 31.19.0 + 31.19.1 enable preview 1.0.0 diff --git a/src/Verify.Expecto/Verifier_String.cs b/src/Verify.Expecto/Verifier_String.cs index edf1859db3..1ac5822b87 100644 --- a/src/Verify.Expecto/Verifier_String.cs +++ b/src/Verify.Expecto/Verifier_String.cs @@ -7,6 +7,7 @@ public static partial class Verifier [Pure] public static SettingsTask Verify( string name, + [StringSyntax("*")] string? target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") @@ -18,6 +19,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( string name, + [StringSyntax("*")] Task target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") @@ -29,6 +31,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( string name, + [StringSyntax("*")] string? target, string extension, VerifySettings? settings = null, @@ -41,6 +44,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( string name, + [StringSyntax("*")] Task target, string extension, VerifySettings? settings = null, diff --git a/src/Verify.Fixie/Verifier_String.cs b/src/Verify.Fixie/Verifier_String.cs index f27ac43779..192532f7c6 100644 --- a/src/Verify.Fixie/Verifier_String.cs +++ b/src/Verify.Fixie/Verifier_String.cs @@ -4,6 +4,7 @@ public static partial class Verifier { [Pure] public static SettingsTask Verify( + [StringSyntax("*")] string? target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") => @@ -11,6 +12,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] Task target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") => @@ -18,6 +20,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] string? target, string extension, VerifySettings? settings = null, @@ -26,6 +29,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] Task target, string extension, VerifySettings? settings = null, diff --git a/src/Verify.MSTest/Verifier_String.cs b/src/Verify.MSTest/Verifier_String.cs index aa3f710c7c..204d2bccde 100644 --- a/src/Verify.MSTest/Verifier_String.cs +++ b/src/Verify.MSTest/Verifier_String.cs @@ -4,6 +4,7 @@ partial class Verifier { [Pure] public static SettingsTask Verify( + [StringSyntax("*")] string? target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") => @@ -11,6 +12,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] Task target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") => @@ -18,6 +20,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] string? target, string extension, VerifySettings? settings = null, @@ -26,6 +29,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] Task target, string extension, VerifySettings? settings = null, diff --git a/src/Verify.MSTest/VerifyBase_String.cs b/src/Verify.MSTest/VerifyBase_String.cs index fde5f057b2..059bc359ce 100644 --- a/src/Verify.MSTest/VerifyBase_String.cs +++ b/src/Verify.MSTest/VerifyBase_String.cs @@ -6,6 +6,7 @@ partial class VerifyBase [Pure] public SettingsTask Verify( + [StringSyntax("*")] string? target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") => @@ -13,6 +14,7 @@ public SettingsTask Verify( [Pure] public SettingsTask Verify( + [StringSyntax("*")] Task target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") => @@ -20,6 +22,7 @@ public SettingsTask Verify( [Pure] public SettingsTask Verify( + [StringSyntax("*")] string? target, string extension, VerifySettings? settings = null, @@ -28,6 +31,7 @@ public SettingsTask Verify( [Pure] public SettingsTask Verify( + [StringSyntax("*")] Task target, string extension, VerifySettings? settings = null, diff --git a/src/Verify.NUnit/Verifier_String.cs b/src/Verify.NUnit/Verifier_String.cs index 59424e1ed9..1590714a89 100644 --- a/src/Verify.NUnit/Verifier_String.cs +++ b/src/Verify.NUnit/Verifier_String.cs @@ -4,6 +4,7 @@ public static partial class Verifier { [Pure] public static SettingsTask Verify( + [StringSyntax("*")] string? target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") => @@ -11,6 +12,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] Task target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") => @@ -18,6 +20,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] string? target, string extension, VerifySettings? settings = null, @@ -26,6 +29,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] Task target, string extension, VerifySettings? settings = null, diff --git a/src/Verify.NUnit/VerifyBase_String.cs b/src/Verify.NUnit/VerifyBase_String.cs index 748c112c65..29b1b3be15 100644 --- a/src/Verify.NUnit/VerifyBase_String.cs +++ b/src/Verify.NUnit/VerifyBase_String.cs @@ -4,18 +4,21 @@ public partial class VerifyBase { [Pure] public SettingsTask Verify( + [StringSyntax("*")] string? target, VerifySettings? settings = null) => Verifier.Verify(target, settings ?? this.settings, sourceFile); [Pure] public SettingsTask Verify( + [StringSyntax("*")] Task target, VerifySettings? settings = null) => Verifier.Verify(target, settings ?? this.settings, sourceFile); [Pure] public SettingsTask Verify( + [StringSyntax("*")] string? target, string extension, VerifySettings? settings = null) => @@ -23,6 +26,7 @@ public SettingsTask Verify( [Pure] public SettingsTask Verify( + [StringSyntax("*")] Task target, string extension, VerifySettings? settings = null) => diff --git a/src/Verify.TUnit/Verifier_String.cs b/src/Verify.TUnit/Verifier_String.cs index 10b88eb264..2d53c7b664 100644 --- a/src/Verify.TUnit/Verifier_String.cs +++ b/src/Verify.TUnit/Verifier_String.cs @@ -4,6 +4,7 @@ public static partial class Verifier { [Pure] public static SettingsTask Verify( + [StringSyntax("*")] string? target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") => @@ -11,6 +12,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] Task target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") => @@ -18,6 +20,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] string? target, string extension, VerifySettings? settings = null, @@ -26,6 +29,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] Task target, string extension, VerifySettings? settings = null, diff --git a/src/Verify.XunitV3/Verifier_String.cs b/src/Verify.XunitV3/Verifier_String.cs index b142fc4699..0f9801c33e 100644 --- a/src/Verify.XunitV3/Verifier_String.cs +++ b/src/Verify.XunitV3/Verifier_String.cs @@ -4,6 +4,7 @@ public static partial class Verifier { [Pure] public static SettingsTask Verify( + [StringSyntax("*")] string? target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") => @@ -11,6 +12,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] Task target, VerifySettings? settings = null, [CallerFilePath] string sourceFile = "") => @@ -18,6 +20,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] string? target, string extension, VerifySettings? settings = null, @@ -26,6 +29,7 @@ public static SettingsTask Verify( [Pure] public static SettingsTask Verify( + [StringSyntax("*")] Task target, string extension, VerifySettings? settings = null, diff --git a/src/Verify.XunitV3/VerifyBase_String.cs b/src/Verify.XunitV3/VerifyBase_String.cs index 536315afb4..e157f71354 100644 --- a/src/Verify.XunitV3/VerifyBase_String.cs +++ b/src/Verify.XunitV3/VerifyBase_String.cs @@ -4,18 +4,21 @@ public partial class VerifyBase { [Pure] public SettingsTask Verify( + [StringSyntax("*")] string? target, VerifySettings? settings = null) => Verifier.Verify(target, settings ?? this.settings, sourceFile); [Pure] public SettingsTask Verify( + [StringSyntax("*")] Task target, VerifySettings? settings = null) => Verifier.Verify(target, settings ?? this.settings, sourceFile); [Pure] public SettingsTask Verify( + [StringSyntax("*")] string? target, string extension, VerifySettings? settings = null) => @@ -23,6 +26,7 @@ public SettingsTask Verify( [Pure] public SettingsTask Verify( + [StringSyntax("*")] Task target, string extension, VerifySettings? settings = null) => diff --git a/src/Verify/Verifier/InnerVerifier_String.cs b/src/Verify/Verifier/InnerVerifier_String.cs index bebf4aed40..8b8d2ad1f9 100644 --- a/src/Verify/Verifier/InnerVerifier_String.cs +++ b/src/Verify/Verifier/InnerVerifier_String.cs @@ -2,22 +2,22 @@ partial class InnerVerifier { - public async Task VerifyString(Task task) + public async Task VerifyString([StringSyntax("*")] Task task) { var value = await task; return await VerifyString(value); } - public Task VerifyString(string? value) => + public Task VerifyString([StringSyntax("*")] string? value) => VerifyInner(value, null, emptyTargets, true, false); - public async Task VerifyString(Task task, string extension) + public async Task VerifyString([StringSyntax("*")] Task task, string extension) { var value = await task; return await VerifyString(value, extension); } - public Task VerifyString(string? value, string extension) => + public Task VerifyString([StringSyntax("*")] string? value, string extension) => VerifyInner( [ new(extension, value ?? "null")