Repository navigation
fix(tri): the cached marker counts columns, not rows (#2492) - #2540
Merged
Merged
Conversation
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-measuring
verify_emit_bitexact.pyproduced a row with two columns measured and three reused, labelled[cached]wholesale — under-claiming rather than over-claiming, so the safe direction, and still wrong. The point of the marker is that a reader can tell which they are looking at.Three states now, verified on one gate: no marker when fresh,
[cached]when every column is reused, and[3 cached, 2 fresh]when mixed. The mixed case was produced by marking two cache entries stale by hand, which is the only way to reach it deliberately.Refs #2492