Skip to content

Commit f5ebce6

Browse files
authored
docs(config): avoid over-exposing GITHUB_TOKEN (#332)
The GITHUB_TOKEN in this example _should_ be just read-only token but in any case secrets should not be exposed to code that does not need them. In this case pip does not need to authenticate to GitHub.
1 parent 582b6ac commit f5ebce6

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

docs/usage/configuration.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -121,10 +121,10 @@ parallel build is finished::
121121
runs-on: ubuntu-latest
122122
container: python:3-slim
123123
steps:
124+
- name: Install coveralls
125+
run: pip3 install --upgrade coveralls
124126
- name: Finished
125-
run: |
126-
pip3 install --upgrade coveralls
127-
coveralls --service=github --finish
127+
run: coveralls --service=github --finish
128128
env:
129129
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
130130

0 commit comments

Comments
 (0)